-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Touch scrolling zooming non native #584
Open
pketh
wants to merge
17
commits into
main
Choose a base branch
from
touch-scrolling-zooming-non-native
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
better reflects intent of dont run more than once per 10ms
better reflects intent of dont run more than once per 10ms
…ve' into touch-scrolling-zooming-non-native
…t update it during zoom sliding space: fix zooming in extends pagesize to prevent cut off
Might need to abandon this again. Hit a wall where zooming in cuts off the scrollable area top and left. Have to use transforms for all pan and scroll to get this working |
use for android? |
move scroll utils/calls (anything with window.scroll , or window.clientX,Y , window.page) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace native touch swiping and pinch zooming w desktop pan and zoom .
fixes android window.scroll pos bugs and ios jittery/janky header/footer pos
swipe needs to be not native bc touch events during native momentum scroll cannot be intercepted by app