Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RSS 功能调整和问题修复 #272

Merged
merged 4 commits into from
Feb 13, 2025
Merged

RSS 功能调整和问题修复 #272

merged 4 commits into from
Feb 13, 2025

Conversation

Jinvic
Copy link
Contributor

@Jinvic Jinvic commented Feb 10, 2025

这个 PR 做了什么?

  • fix: 未显示置顶memo
  • fix: 错误显示私密memo
  • feat: 展示memo数量修改为15
  • feat: 置顶memo在rss中不会置顶,但添加一行 【置顶】 作为标识

- fix: 未显示置顶memo
- fix: 错误显示私密memo
- feat: 展示memo数量修改为15
- feat: 置顶memo在rss中不会置顶,但添加一行 **【置顶】** 作为标识
@dinphy
Copy link
Contributor

dinphy commented Feb 11, 2025

不知为啥,用生成的地址可以直接访问,但十年之约的订阅抓取不到rss的地址!

- [ ] Invalid email address
    在实现rss功能时用户表里还没有邮箱,所以在Author字段中只填了Name没填Email。现在邮箱已在邮件通知分支中添加,不过为了避免重复混淆,Rss分支上暂不处理。
- [x] Feeds should not be served with the "text/plain" media type
    只在前端链接中指定了`type="application/rss+xml"`,但后端接口没有正确设定Header中的Content-Type,已修正。
- [x] item should contain a guid element
    字段缺失,已修正
- [ ] Missing atom:link with rel="self"
    `gorilla\feeds`库的问题,见[gorilla/feeds kingwrcy#111](gorilla/feeds#111)
@Jinvic
Copy link
Contributor Author

Jinvic commented Feb 11, 2025

使用W3C Feed Validation Service验证rss订阅链接确实发现了一些问题:

  • Invalid email address
    在实现rss功能时用户表里还没有邮箱,所以在Author字段中只填了Name没填Email。现在邮箱已在邮件通知分支中添加,不过为了避免重复混淆,Rss分支上暂不处理。
  • Feeds should not be served with the "text/plain" media type
    只在前端链接中指定了type="application/rss+xml",但后端接口没有正确设定Header中的Content-Type,已修正。
  • item should contain a guid element
    字段缺失,已修正
  • Missing atom:link with rel="self"
    gorilla\feeds库的问题,见 [BUG] W3C: Missing atom:link with rel="self" gorilla/feeds#111

但以上问题也不一定是导致你的问题的原因,因为即使存在上述rss不够规范的问题,RSSHub-Radar和Follow等工具仍能正确获取解析Rss订阅链接。

@Jinvic Jinvic marked this pull request as draft February 12, 2025 07:35
@dinphy
Copy link
Contributor

dinphy commented Feb 12, 2025

使用W3C Feed Validation Service验证rss订阅链接确实发现了一些问题:

  • Invalid email address
    在实现rss功能时用户表里还没有邮箱,所以在Author字段中只填了Name没填Email。现在邮箱已在邮件通知分支中添加,不过为了避免重复混淆,Rss分支上暂不处理。
  • Feeds should not be served with the "text/plain" media type
    只在前端链接中指定了type="application/rss+xml",但后端接口没有正确设定Header中的Content-Type,已修正。
  • item should contain a guid element
    字段缺失,已修正
  • Missing atom:link with rel="self"
    gorilla\feeds库的问题,见gorilla/feeds #111

但以上问题也不一定是导致你的问题的原因,因为即使存在上述rss不够规范的问题,RSSHub-Radar和Follow等工具仍能正确获取解析Rss订阅链接。

RSS 在 十年之约 订阅成功了,但我修改了地址,自动生成的 /rss?frontend_host=https%3A%2F%2Fm.xwsir.com 中,%3A%2F%2F 识别不了,改为 :// 才成功的。

@Jinvic
Copy link
Contributor Author

Jinvic commented Feb 13, 2025

W3C Feed Validation Service验证失败:

@Jinvic Jinvic marked this pull request as ready for review February 13, 2025 02:28
@kingwrcy kingwrcy merged commit 0f4e41e into kingwrcy:dev Feb 13, 2025
@xuewenG xuewenG changed the title bugfix(rss): rss功能调整&bug修复 RSS 功能调整和问题修复 Feb 14, 2025
@xuewenG xuewenG added the bugfix Bug fix label Feb 14, 2025
@xuewenG xuewenG added this to the v0.2.9 milestone Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants