Repository navigation
Drop the All The Apps button from the app bar - #4
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The focused removal is consistent across markup, styles, checks, and documentation, with no unresolved findings.
0 open findings
What changed in this PR
Removes the redundant “All The Apps” button from the shared app bar, leaving catalog navigation to the site navbar.
Changes:
- Removes the button, its host-data reads, and associated styles.
- Adds checks against reintroducing the button or its styles.
- Updates documentation to describe the navbar-only bar.
| File | Description |
|---|---|
| tests/check_clients.js | Guards against restoring the button and styles. |
| README.md | Documents the navbar-only bar and updated host inputs. |
| layouts/partials/app-kit/hero.html | Removes the catalog button and its data reads. |
| chrome.css | Removes obsolete row, action, and button rules. |
| AGENTS.md | Updates shared app-bar guidance. |
🧠 Review effort: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
tig
marked this pull request as ready for review
October 7, 2026 20:21
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The app bar is the site navbar. The Apps link in that navbar is the way back to the catalog, so the bar no longer renders an All The Apps button.
The hero partial no longer reads
allAppsor renders the link. The row, actions, and button rules are gone fromchrome.css. The client check fails if the button or those rules come back. The README and AGENTS.md describe the bar as the navbar.