Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add hamburger menu to navigation bar #994

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

praseodym
Copy link
Contributor

@praseodym praseodym commented Feb 7, 2025

- Add compass, file, hamburger, laptop, and users icons.
- Extend and translate the icons documentation and move it to the
  `documentatie` directory
@praseodym praseodym added the frontend Issues or pull requests that relate to the frontend label Feb 7, 2025
@praseodym praseodym self-assigned this Feb 7, 2025
Copy link

github-actions bot commented Feb 7, 2025

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars

Show details

Sigrid compared your code against the baseline of 2025-02-10.

👍 What went well?

You fixed or improved 0 refactoring candidates.

👎 What could be better?

Unfortunately, 2 refactoring candidates were introduced or got worse.

Risk System property Location
🔴 Unit Size
(Worsened)
frontend/lib/ui/style/variables.css
variables.css
root
🟡 Unit Size
(Introduced)
frontend/app/component/navbar/NavBar.module.css
NavBar.module.css:.nav-bar-menu

📚 Remaining technical debt

2 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid** to explore your technical debt

⭐️ Sigrid ratings

System property System on 2025-02-10 Before changes New/changed code
Volume 5.2 N/A N/A
Duplication 4.3 5.5 5.5
Unit Size 2.4 1.7 2.3
Unit Complexity 3.4 2.3 3.2
Unit Interfacing 3.0 5.5 5.5
Module Coupling 4.0 N/A 5.5
Component Independence 2.8 N/A N/A
Component Entanglement 3.7 N/A N/A
Maintainability 3.6 3.5 4.0

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.82%. Comparing base (18917fc) to head (37483d9).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #994      +/-   ##
==========================================
+ Coverage   89.76%   89.82%   +0.06%     
==========================================
  Files         248      249       +1     
  Lines       12987    13065      +78     
  Branches     1318     1325       +7     
==========================================
+ Hits        11658    11736      +78     
  Misses       1235     1235              
  Partials       94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Lionqueen94
Lionqueen94 previously approved these changes Feb 7, 2025
Copy link
Contributor

@jorisleker jorisleker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Hamburger looks+works good

One note: On /elections/1#administratorcoordinator I would expect the 'Verkiezingen > version of the menu in stead of the hamburger.

@praseodym
Copy link
Contributor Author

praseodym commented Feb 9, 2025

One note: On /elections/1#administratorcoordinator I would expect the 'Verkiezingen > version of the menu in stead of the hamburger.

The Figma design has the Verkiezingen/Gebruikers/Werkplekken/Logs menu here, should I change it to that one? I also noticed that the hamburger is shown for the typist (invoerder) role on that page as well, I'll fix that too.

@jorisleker
Copy link
Contributor

The Figma design has the Verkiezingen/Gebruikers/Werkplekken/Logs menu here, should I change it to that one? I also noticed that the hamburger is shown for the typist (invoerder) role on that page as well, I'll fix that too.

Sharp, it should be the menu here!
And the typist should never have the hamburger, so yes please fix that

lkleuver
lkleuver previously approved these changes Feb 10, 2025
frontend/app/component/navbar/NavBarMenu.tsx Outdated Show resolved Hide resolved
Lionqueen94
Lionqueen94 previously approved these changes Feb 10, 2025
documentatie/style-guide/README.md Outdated Show resolved Hide resolved
frontend/app/component/navbar/NavBar.module.css Outdated Show resolved Hide resolved
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues or pull requests that relate to the frontend
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement navigation bar menu for administrator and coordinator
5 participants