-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add hamburger menu to navigation bar #994
base: main
Are you sure you want to change the base?
Conversation
- Add compass, file, hamburger, laptop, and users icons. - Extend and translate the icons documentation and move it to the `documentatie` directory
Sigrid maintainability feedback✅ You wrote maintainable code and achieved your objective of 3.5 stars Show detailsSigrid compared your code against the baseline of 2025-02-10. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid** to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #994 +/- ##
==========================================
+ Coverage 89.76% 89.82% +0.06%
==========================================
Files 248 249 +1
Lines 12987 13065 +78
Branches 1318 1325 +7
==========================================
+ Hits 11658 11736 +78
Misses 1235 1235
Partials 94 94 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✅ Hamburger looks+works good
One note: On /elections/1#administratorcoordinator I would expect the 'Verkiezingen > version of the menu in stead of the hamburger.
The Figma design has the Verkiezingen/Gebruikers/Werkplekken/Logs menu here, should I change it to that one? I also noticed that the hamburger is shown for the typist (invoerder) role on that page as well, I'll fix that too. |
Sharp, it should be the menu here! |
Resolves #920
Check out: