Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some improvements to Tables and OverviewPage #990

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Lionqueen94
Copy link
Contributor

@Lionqueen94 Lionqueen94 commented Feb 7, 2025

Description

  • Added Footer to OverviewLayout and removed from all child pages, reason: ElectionReportPage was missing the Footer
  • Set the correct gray color for the Chevron in the icon with fill because background-image color cannot be set, meaning the Chevron in the Table.LinkRow was black instead of gray
  • Made sure Table.LinkRow last Cell has increased padding to make sure the padding around the Chevron is as designed
  • Made sure all Table functions accept a className
  • Renamed Table.Column to Table.HeaderCell since it can also be used in a row
  • Added a scope="row" | "col" with a default set to "col" to Table.HeaderCell to allow row th usage
  • Made sure Table.HeaderCell can have no children, equal to the implementation of Table.Cell
  • Showing a message that no elections exist on OverviewPage instead of throwing a harsh error, separate designs for typist and administrator are implemented
  • Added tests for OverviewPage
  • Corrected error icon color in Alert, ProgressList and StatusList and small alert text color
  • Made sure there is no empty table when there are no polling stations to input on polling station choice page

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.15%. Comparing base (18917fc) to head (5fe59c8).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #990      +/-   ##
==========================================
+ Coverage   89.76%   90.15%   +0.38%     
==========================================
  Files         248      247       -1     
  Lines       12987    12983       -4     
  Branches     1318     1327       +9     
==========================================
+ Hits        11658    11705      +47     
+ Misses       1235     1184      -51     
  Partials       94       94              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

github-actions bot commented Feb 7, 2025

Sigrid maintainability feedback

✅ You wrote maintainable code and achieved your objective of 3.5 stars

Show details

Sigrid compared your code against the baseline of 2025-02-10.

👍 What went well?

You fixed or improved 1 refactoring candidates.

Risk System property Location
🟡 Unit Size
(Improved)
frontend/app/component/form/data_entry/polling_station_choice/PollingStationsList.tsx
PollingStationsList.tsx.PollingStationsList(PollingStationsListProps)

👎 What could be better?

Unfortunately, 1 refactoring candidates were introduced or got worse.

Risk System property Location
🟡 Unit Size
(Worsened)
frontend/app/component/form/data_entry/polling_station_choice/PollingStationChoiceForm.tsx
PollingStationChoiceForm.tsx.PollingStationChoiceForm(PollingStationChoiceFormProps)

📚 Remaining technical debt

8 refactoring candidates didn't get better or worse, but are still present in the code you touched.

View this system in Sigrid** to explore your technical debt

⭐️ Sigrid ratings

System property System on 2025-02-10 Before changes New/changed code
Volume 5.2 N/A N/A
Duplication 4.3 5.5 5.5
Unit Size 2.4 2.7 2.8
Unit Complexity 3.4 3.7 3.8
Unit Interfacing 3.0 5.5 5.5
Module Coupling 4.0 5.5 5.5
Component Independence 2.8 N/A N/A
Component Entanglement 3.7 N/A N/A
Maintainability 3.6 4.4 4.5

💬 Did you find this feedback helpful?

We would like to know your thoughts to make Sigrid better.
Your username will remain confidential throughout the process.


View this system in Sigrid

@Lionqueen94 Lionqueen94 changed the title Some small fixes Some small changes to Tables and OverviewPage Feb 7, 2025
@Lionqueen94 Lionqueen94 changed the title Some small changes to Tables and OverviewPage Some improvements to Tables and OverviewPage Feb 7, 2025
@praseodym praseodym added the frontend Issues or pull requests that relate to the frontend label Feb 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues or pull requests that relate to the frontend
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

5 participants