-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Some improvements to Tables and OverviewPage #990
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #990 +/- ##
==========================================
+ Coverage 89.76% 90.15% +0.38%
==========================================
Files 248 247 -1
Lines 12987 12983 -4
Branches 1318 1327 +9
==========================================
+ Hits 11658 11705 +47
+ Misses 1235 1184 -51
Partials 94 94 ☔ View full report in Codecov by Sentry. |
Sigrid maintainability feedback✅ You wrote maintainable code and achieved your objective of 3.5 stars Show detailsSigrid compared your code against the baseline of 2025-02-10. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid** to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
…small alert text color
…to input on polling station choice page
frontend/app/component/form/data_entry/polling_station_choice/PollingStationChoiceForm.tsx
Show resolved
Hide resolved
…ron in LinkRow, increased padding instead to adhere to design
…added no elections text for non admins on OverviewPage
Description
Footer
toOverviewLayout
and removed from all child pages, reason:ElectionReportPage
was missing the FooterTable.LinkRow
was black instead of grayTable.LinkRow
last Cell has increased padding to make sure the padding around the Chevron is as designedTable
functions accept aclassName
Table.Column
toTable.HeaderCell
since it can also be used in a rowscope="row" | "col"
with a default set to"col"
toTable.HeaderCell
to allow rowth
usageTable.HeaderCell
can have no children, equal to the implementation ofTable.Cell
OverviewPage
instead of throwing a harsh error, separate designs for typist and administrator are implementedOverviewPage
Alert
,ProgressList
andStatusList
and small alert text color