Fix PDF for empty polling station type #969
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Typst template did not handle `polling_station_type` being `None` properly, which is fixed by checking that the `polling_station_type` key exists. This also contains a few minor layout changes and sets the document language to Dutch.
Sigrid maintainability feedback💭️ You did not change any files that are measured by Sigrid |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #969 +/- ##
=======================================
Coverage 89.80% 89.80%
=======================================
Files 238 238
Lines 12561 12561
Branches 1281 1281
=======================================
Hits 11281 11281
Misses 1191 1191
Partials 89 89 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Typst template did not handle
polling_station_typebeingNoneproperly, which is fixed by checking that thepolling_station_typekey exists.This also contains a few minor layout changes and sets the document language to Dutch.