Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update rand to 0.9.0 #958

Merged
merged 1 commit into from
Feb 4, 2025
Merged

Update rand to 0.9.0 #958

merged 1 commit into from
Feb 4, 2025

Conversation

praseodym
Copy link
Contributor

Resolves #956

@praseodym praseodym requested a review from a team as a code owner February 4, 2025 09:27
@praseodym praseodym self-assigned this Feb 4, 2025
@praseodym praseodym added dependencies Pull requests that update a dependency file backend Issues or pull requests that relate to the backend rust Pull requests that update Rust code labels Feb 4, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 4, 2025

Sigrid maintainability feedback

💭️ You did not change any files that are measured by Sigrid

View this system in Sigrid

@codecov Codecov
Copy link

codecov bot commented Feb 4, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.22%. Comparing base (4fdcbf7) to head (cf46044).

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #958   +/-   ##
=======================================
  Coverage   87.22%   87.22%           
=======================================
  Files         264      264           
  Lines       13556    13556           
  Branches     1298     1298           
=======================================
  Hits        11824    11824           
  Misses       1643     1643           
  Partials       89       89

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@praseodym praseodym enabled auto-merge February 4, 2025 09:31
@Lionqueen94 Lionqueen94 changed the title Update to rand 0.9.0 Update rand to 0.9.0 Feb 4, 2025
@praseodym praseodym added this pull request to the merge queue Feb 4, 2025
cikzh
cikzh approved these changes Feb 4, 2025
View reviewed changes
Copy link
Contributor

@cikzh cikzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think it's wise that @marlonbaeten also reviews this

@cikzh cikzh removed this pull request from the merge queue due to a manual request Feb 4, 2025
@praseodym praseodym added this pull request to the merge queue Feb 4, 2025
Merged via the queue into main with commit 4d200d0 Feb 4, 2025
21 checks passed
@praseodym praseodym deleted the 956-rand-0.9.0 branch February 4, 2025 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marlonbaeten marlonbaeten marlonbaeten approved these changes

@cikzh cikzh cikzh approved these changes

@Lionqueen94 Lionqueen94 Lionqueen94 approved these changes

@rnijveld rnijveld Awaiting requested review from rnijveld

Assignees

@praseodym praseodym

Labels
backend Issues or pull requests that relate to the backend dependencies Pull requests that update a dependency file rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rand 0.9.0 causes issues with cargo-llvm-cov
4 participants
@praseodym @marlonbaeten @cikzh @Lionqueen94