Keep React Router version 7.1.3 #954
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oliver3
requested review from
praseodym,
lkleuver,
Lionqueen94 and
jschuurk-kr
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #954 +/- ##
=======================================
Coverage 87.22% 87.22%
=======================================
Files 264 264
Lines 13556 13556
Branches 1298 1298
=======================================
Hits 11824 11824
Misses 1643 1643
Partials 89 89 ☔ View full report in Codecov by Sentry. |
Sigrid maintainability feedback💭️ You did not change any files that are measured by Sigrid |
|
I think #942 (comment) should fix this too. Is there an issue in react-router for this problem? |
I'm not quite sure what the issue is still, but I could not find anything related in their issues. |
|
#942 (comment) resolved this, Dependabot created #955 without the react-router update. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update React Router to 7.1.4 or 7.1.5 causes DataEntryHomePage.test.tsx to fail. Issue #953 has been created to fix this.