-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resume data entry (without form state) #364
Conversation
frontend/lib/api/form/pollingstation/PollingStationFormController.tsx
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly reviewed the backend code which LGTM!
@praseodym should I see the incomplete data entries in an alert on the pick polling station page? (I don't, but not sure if it was intended that way) |
No, that's for #369. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
State of the 'accept warnings' checkboxes do not seem to be remembered. Guess they should, bit weird to re-accept warnings to be able to see next steps
This PR implements the minimal version that does not restore the form state (like accepted warnings), see the PR description and the epic (#137). Saving and restoring the form state is part of a later issue. |
Ah okay. Wasn't aware that checked checkboxes are part of the state of the form and not of the data. But if this will be fixed in a later issue, 👌 |
This PR is a minimal implementation of resuming data entry, without saving/recovering state like accepted warnings. This means that the data will be filled in, the form will start at the 'Recounted' page and the left side navigation will not show progress. Navigating to the next page will also show previous data on that page.
Saving and recovering the full form state is part of a future issue in #137.
Also note that the Mock Service Worker build does not currently support resuming a data entry, implementing this is also part of a future issue in #137.
Resolves #355.