Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resume data entry (without form state) #364

Merged
merged 6 commits into from
Sep 24, 2024
Merged

Conversation

praseodym
Copy link
Contributor

@praseodym praseodym commented Sep 23, 2024

This PR is a minimal implementation of resuming data entry, without saving/recovering state like accepted warnings. This means that the data will be filled in, the form will start at the 'Recounted' page and the left side navigation will not show progress. Navigating to the next page will also show previous data on that page.

Saving and recovering the full form state is part of a future issue in #137.

Also note that the Mock Service Worker build does not currently support resuming a data entry, implementing this is also part of a future issue in #137.

Resolves #355.

@praseodym praseodym requested review from jorisleker and a team as code owners September 23, 2024 12:13
@praseodym praseodym requested review from lkleuver, cikzh and Lionqueen94 and removed request for a team September 23, 2024 12:13
@praseodym praseodym self-assigned this Sep 23, 2024
@praseodym praseodym added backend Issues or pull requests that relate to the backend frontend Issues or pull requests that relate to the frontend tests Issues or pull requests that relate to tests labels Sep 23, 2024
Copy link
Contributor

@cikzh cikzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly reviewed the backend code which LGTM!

@praseodym praseodym requested a review from lkleuver September 23, 2024 14:38
@jorisleker
Copy link
Contributor

@praseodym should I see the incomplete data entries in an alert on the pick polling station page? (I don't, but not sure if it was intended that way)

@praseodym
Copy link
Contributor Author

@praseodym should I see the incomplete data entries in an alert on the pick polling station page? (I don't, but not sure if it was intended that way)

No, that's for #369.

Copy link
Contributor

@jorisleker jorisleker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

State of the 'accept warnings' checkboxes do not seem to be remembered. Guess they should, bit weird to re-accept warnings to be able to see next steps

@praseodym
Copy link
Contributor Author

State of the 'accept warnings' checkboxes do not seem to be remembered. Guess they should, bit weird to re-accept warnings to be able to see next steps

This PR implements the minimal version that does not restore the form state (like accepted warnings), see the PR description and the epic (#137). Saving and restoring the form state is part of a later issue.

@jorisleker
Copy link
Contributor

State of the 'accept warnings' checkboxes do not seem to be remembered. Guess they should, bit weird to re-accept warnings to be able to see next steps

This PR implements the minimal version that does not restore the form state (like accepted warnings), see the PR description and the epic (#137). Saving and restoring the form state is part of a later issue.

Ah okay. Wasn't aware that checked checkboxes are part of the state of the form and not of the data. But if this will be fixed in a later issue, 👌

@jorisleker jorisleker self-requested a review September 24, 2024 09:00
@praseodym praseodym added this pull request to the merge queue Sep 24, 2024
Merged via the queue into main with commit f15b200 Sep 24, 2024
7 checks passed
@praseodym praseodym deleted the 355-resume-data-entry-minimal branch September 24, 2024 09:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend Issues or pull requests that relate to the backend frontend Issues or pull requests that relate to the frontend tests Issues or pull requests that relate to tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Resume data entry without state
6 participants