-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Form shortcuts #348
Form shortcuts #348
Conversation
This PR solves |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Missing the added hint (shift + down arrow) in the bottom bar.
- Copy of that hint differs for lists and other form sections.
- The hint should appear below the 'accept warnings' checkbox if that is shown.
(you can leave out the 'spacebar' hint untill that is implemented in #207)
add shortcut hint ui
frontend/app/component/form/data_entry/differences/DifferencesForm.tsx
Outdated
Show resolved
Hide resolved
frontend/app/component/form/data_entry/voters_and_votes/VotersAndVotesForm.tsx
Outdated
Show resolved
Hide resolved
Does it (design wise) make sense to add the Shift+↓ shortcut on the Voters and Votes and Differences pages? I'd say they are only useful on the political group votes pages. |
That's a fair point. We could leave out the hint / description at the bottom of the page. Not sure we should leave out the entire shortcut. Prefer consistent behavior over all our forms. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Retested, works as expected now!
Moved focus shortcuts to Form component to handle both submit and focus events.
Closes #207