Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Form shortcuts #348

Merged
merged 11 commits into from
Sep 19, 2024
Merged

Form shortcuts #348

merged 11 commits into from
Sep 19, 2024

Conversation

lkleuver
Copy link
Contributor

@lkleuver lkleuver commented Sep 17, 2024

Moved focus shortcuts to Form component to handle both submit and focus events.

Closes #207

@Lionqueen94
Copy link
Contributor

This PR solves ENTER from last input field moves focus to submit button. from #207 but not SHIFT + UP arrow: navigate to first input on page (the first candidate) is this indeed intended?

Copy link
Contributor

@jorisleker jorisleker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing the added hint (shift + down arrow) in the bottom bar.

  • Copy of that hint differs for lists and other form sections.
  • The hint should appear below the 'accept warnings' checkbox if that is shown.

(you can leave out the 'spacebar' hint untill that is implemented in #207)
Scherm­afbeelding 2024-09-18 om 08 31 07

@lkleuver
Copy link
Contributor Author

This PR solves ENTER from last input field moves focus to submit button. from #207 but not SHIFT + UP arrow: navigate to first input on page (the first candidate) is this indeed intended?

I could fully implement #207 perhaps excluding the spacebar search?
shift up is a small change

@praseodym
Copy link
Contributor

Does it (design wise) make sense to add the Shift+↓ shortcut on the Voters and Votes and Differences pages? I'd say they are only useful on the political group votes pages.

@jorisleker
Copy link
Contributor

Does it (design wise) make sense to add the Shift+↓ shortcut on the Voters and Votes and Differences pages? I'd say they are only useful on the political group votes pages.

That's a fair point. We could leave out the hint / description at the bottom of the page. Not sure we should leave out the entire shortcut. Prefer consistent behavior over all our forms.

Copy link
Contributor

@jorisleker jorisleker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Retested, works as expected now!

@jorisleker jorisleker added this pull request to the merge queue Sep 19, 2024
Merged via the queue into main with commit c58f4b8 Sep 19, 2024
7 checks passed
@jorisleker jorisleker deleted the form-shortcuts branch September 19, 2024 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve keyboard navigation on list data entry page
5 participants