Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Frontend: A few design fixes #227

Merged
merged 1 commit into from
Aug 6, 2024
Merged

Frontend: A few design fixes #227

merged 1 commit into from
Aug 6, 2024

Conversation

Lionqueen94
Copy link
Contributor

@Lionqueen94 Lionqueen94 commented Aug 5, 2024

Done:

Fixed from #101 :

  • when a list has exactly n*25 candidates, the spacer/separator for the next 25 candidates is shown. The separator should only be added if there is a (n*25)+1'nd candidate. Scherm­afbeelding 2024-08-01 om 11 13 17
  • The zebra-striping of the rows does not match the striping used in the paper forms. On paper, the first row of each 25 rows is white. In our digital form, row 26 and row 76 have a dark background. Each block of 25 rows should start with a white background.
    Scherm­afbeelding 2024-08-05 om 09 49 33

@Lionqueen94 Lionqueen94 added the frontend Issues or pull requests that relate to the frontend label Aug 5, 2024
@Lionqueen94 Lionqueen94 added this to the Demo must haves milestone Aug 5, 2024
@Lionqueen94 Lionqueen94 self-assigned this Aug 5, 2024
@Lionqueen94 Lionqueen94 changed the title A few design fixes Frontend: A few design fixes Aug 5, 2024
@jorisleker jorisleker added this pull request to the merge queue Aug 6, 2024
Merged via the queue into main with commit f43c451 Aug 6, 2024
5 checks passed
@jorisleker jorisleker deleted the some_design_fixes branch August 6, 2024 08:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
frontend Issues or pull requests that relate to the frontend
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants