Use elections api in frontend #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
rnijveld
commented
Jul 24, 2024
•
rnijveld
commented
- ElectionProvider was updated to require an electionId parameter, that parameters is retrieve using the routed url
- Election overview uses the data from useElectionList
- We currently don't yet have a status or role in the election overview. Role column remains empty for now. Status column is always set to 'invoerders bezig' (which is what our current focus is), I've kept the other statuses as a comment for now.
rnijveld
requested review from
praseodym,
lkleuver,
Lionqueen94,
jorisleker and
cikzh
cikzh
requested changes
Jul 24, 2024
rnijveld
force-pushed
the
134-frontend-use-election-api
branch
from
b65c46a to
d54079e
Compare
praseodym
approved these changes
Jul 24, 2024
|
@rnijveld We squash PR commits so there's no reason to amend commits, and rebasing/amending does make it harder to review because then GitHub can't show differences since the last review. |
Sure! Will do that from now on! |
cikzh
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.