-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Uitbreiding woordenlijst #1026
base: main
Are you sure you want to change the base?
Uitbreiding woordenlijst #1026
Conversation
- categorieën toegevoegd - termen toegevoegd
Sigrid maintainability feedback💭️ You did not change any files that are measured by Sigrid |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1026 +/- ##
=======================================
Coverage 89.85% 89.85%
=======================================
Files 249 249
Lines 13073 13073
Branches 1328 1328
=======================================
Hits 11747 11747
Misses 1232 1232
Partials 94 94 ☔ View full report in Codecov by Sentry. |
| kiescolleges Eerste Kamer | | electoral colleges for the Senate | | | ||
| Eilandsraadsverkiezingen | | elections of the Island Councils | | | ||
| herindelingsverkiezingen | | redivision elections | | | ||
| college van burgemeesters en wethouders | B&W | municipal executive of mayor and aldermen | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| college van burgemeesters en wethouders | B&W | municipal executive of mayor and aldermen | | | |
| college van burgemeester en wethouders | B&W | municipal executive of mayor and aldermen | | |
| decentrale stemopneming | DSO | decentralized (vote) counting method | | | ||
| centrale stemopneming | CSO | centralized (vote) counting method | | | ||
|
||
## Acties / status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Het is denk ik handig om de inhoud van de onderstaande tabel op alfabetische volgorde te zetten
| account instellen | | set up account | | | ||
| invoeren | | input | | | ||
| ingevoerd | | input complete | | | ||
| invoer | | input | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use data entry
for anything related to invoer
in the code instead of input
| bezwaren | | objections | | | ||
| klachten | | complaints | | | ||
| onregelmatigheden | | irregularities | | | ||
| bijzonderheden | | circumstances | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| bijzonderheden | | circumstances | | | |
| bijzonderheden | | particulars | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
would 'details' be a good suggestion here?
| voorkeursdrempel | | preference threshold | via EML_NL-standaard | | ||
| voorkeursstem | | preferential vote | via <https://en.wikipedia.org/wiki/Preferential_voting> | | ||
| loting | | draw | | | ||
| systeem van de grootste gemiddelden | | system of largest averages | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| systeem van de grootste gemiddelden | | system of largest averages | | | |
| systeem van de grootste gemiddelden | | system of largest averages | | | |
| systeem van de grootste overschotten | | system of largest surpluses | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wikipedia heeft het over 'largest remainder' ipv 'largest surpluses': https://en.wikipedia.org/wiki/Quota_method
| onverklaard | | unaccounted for | *explain* is alleen uitleggen, je moet hier ook verantwoorden | | ||
| verklaring | | declaration | | | ||
| verklaren | | account for | | | ||
| controleprotocol optellingen | | monitoring protocol for totals | optellingen zijn hier eigenlijk totalen | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
monitoring protocol tabulation and maybe add 'tabulate' or 'tabulation' (the process of totalling votes) to the list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've added some minor comments, mainly based on the EML_NL standard
| Eerste Kamerverkiezing | EK | election of the Senate | | | ||
| gemeenteraadsverkiezingen | GR | elections of the municipal council | | | ||
| provinciale statenverkiezingen | PS | elections of the provincial council | | | ||
| waterschapsverkiezingen | WS | elections of the Water authority | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The EML_NL standard also uses AB
as an abbreviation for waterschapsverkiezingen:
https://github.com/kiesraad/EML_NL/blob/54d9d39652f5d90a0f78b68cb075a049be7f1beb/xsd/kiesraad-eml-extensions.xsd#L55
| waterschapsverkiezingen | WS | elections of the Water authority | | | ||
| Europees Parlementsverkiezing | EP | election of the European Parliament | | | ||
| kiescolleges Eerste Kamer | | electoral colleges for the Senate | | | ||
| Eilandsraadsverkiezingen | | elections of the Island Councils | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Abbreviation ER
is used in the EML_NL standard:
https://github.com/kiesraad/EML_NL/blob/54d9d39652f5d90a0f78b68cb075a049be7f1beb/xsd/kiesraad-eml-extensions.xsd#L85C1-L85C8
| Europees Parlementsverkiezing | EP | election of the European Parliament | | | ||
| kiescolleges Eerste Kamer | | electoral colleges for the Senate | | | ||
| Eilandsraadsverkiezingen | | elections of the Island Councils | | | ||
| herindelingsverkiezingen | | redivision elections | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For publishing data we've used GRh
(for example see https://data.overheid.nl/sites/default/files/dataset/0452b499-1eb8-45d1-9690-59d752724fda/resources/EML%20bestanden%20GRh2020.zip), however the EML_NL standard simply uses GR
here.
| voorkeursdrempel | | preference threshold | via EML_NL-standaard | | ||
| voorkeursstem | | preferential vote | via <https://en.wikipedia.org/wiki/Preferential_voting> | | ||
| loting | | draw | | | ||
| systeem van de grootste gemiddelden | | system of largest averages | | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wikipedia heeft het over 'highest averages' ipv 'largest averages': https://en.wikipedia.org/wiki/Highest_averages_method
| partijloos | | non-party | *non-party candidate* | | ||
| onafhankelijk | | independent | *independent candidate* | | ||
| overleden | | deceased | *deceased candidate* | | ||
| kiesdeler | | electoral divisor | gevonden in een Engels jaarverslag van de KR uit 2007 | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
'electoral quota' is meer gangbaar, zie bijv https://en.wikipedia.org/wiki/Electoral_quota
What's the scope of the changes?
Are there things you want reviewers to definitely take a look at?