-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add user update endpoint #1011
base: main
Are you sure you want to change the base?
Add user update endpoint #1011
Conversation
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #1011 +/- ##
==========================================
- Coverage 89.77% 89.72% -0.05%
==========================================
Files 248 248
Lines 12995 13078 +83
Branches 1318 1320 +2
==========================================
+ Hits 11666 11734 +68
- Misses 1235 1249 +14
- Partials 94 95 +1 ☔ View full report in Codecov by Sentry. |
Sigrid maintainability feedback✅ You wrote maintainable code and achieved your objective of 3.5 stars Show detailsSigrid compared your code against the baseline of 2025-02-11. 👍 What went well?
👎 What could be better?
📚 Remaining technical debt
View this system in Sigrid** to explore your technical debt ⭐️ Sigrid ratings
💬 Did you find this feedback helpful?We would like to know your thoughts to make Sigrid better. |
Closes #873
Adds endpoint to update a user. Also adds the
needs_password_change
flag and sets it to true when the user is newly created, or when a temporary password is set. The handling of the flag is out of scope for this PR.In draft until I've implemented a test for the
needs_password_change
flag