Skip to content

✂️ Feature add baseclip #55

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Oct 17, 2024
Merged

✂️ Feature add baseclip #55

merged 6 commits into from
Oct 17, 2024

Conversation

migbro
Copy link
Member

@migbro migbro commented Oct 16, 2024

Description

Main purpose is to address scRNA data in which cycle lengths were not properly set resulting in workflow failure. Solution was to add a tool to cut read and mate to proper lengths. Also done:

  • Added params to h5 write to be cell ranger reanalyze compatible
  • Ran styler to make R code style-compliant

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Environment:
  • Test files:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings
  • I have committed any related changes to the PR

@migbro migbro added documentation Regarding developer or user documentation feature New functionality bix-dev labels Oct 16, 2024
@migbro migbro self-assigned this Oct 16, 2024
@migbro migbro requested a review from zhangb1 October 16, 2024 20:42
@migbro migbro requested a review from dmiller15 October 17, 2024 14:11
@migbro migbro merged commit 3e2ea1e into master Oct 17, 2024
1 check passed
@migbro migbro deleted the feature/mb-add-baseclip branch October 17, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bix-dev documentation Regarding developer or user documentation feature New functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants