Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keymangreek #3311

Closed
wants to merge 0 commits into from
Closed

keymangreek #3311

wants to merge 0 commits into from

Conversation

tonizo2025
Copy link

keymangreek for mobile devices

@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@tonizo2025
Copy link
Author

keymangreek for mobile devices

Ready to review

@LornaSIL
Copy link
Contributor

It would be best for this keyboard not to start with the word keyman as that is the technology, not important to naming a keyboard. Just the name greek would also be unsufficient since there are so many greek keyboards. If this is modern greek, I believe the ID of modern_greek would still be available. polytonic_greek is also still available as an ID.

In addition, it looks like you will need to look more carefully at how the folder needs to be structured for keyboard packages. Take a look at this page https://github.com/keymanapp/keyboards?tab=readme-ov-file#file-layout Click on Folder and file layout which takes you here: https://help.keyman.com/developer/current-version/reference/file-layout

@mcdurdin
Copy link
Member

mcdurdin commented Feb 2, 2025

It would be best for this keyboard not to start with the word keyman as that is the technology, not important to naming a keyboard. Just the name greek would also be unsufficient since there are so many greek keyboards. If this is modern greek, I believe the ID of modern_greek would still be available. polytonic_greek is also still available as an ID.

The name keymangreek probably needs to change because Keyman is a registered trademark (in Australia). I suggest that you rename the keyboard, but include the name 'keymangr_all' in the list of related keyboards in the keyboard package, and make use of the 'deprecated' flag to indicate that 'keymangr_all' should be upgrade to the new name.

@tonizo2025
Copy link
Author

tonizo2025 commented Feb 4, 2025 via email

@DavidLRowe
Copy link
Contributor

@tonizo2025 As of Keyman Developer v17, the .keyboard_info file is no longer needed. (The description and information on language tag, related keyboards, etc. is now included in the Keyman package source (.kps) file. The documentation needs updating to remove reference to that file.

The readme.htm file is displayed at the beginning of installation on computer, so it's helpful to have a short description of the keyboard to assure the user that the desired keyboard is being installed.

The welcome.htm file (and any images it references) provides the help that is packaged with the keyboard. (We also ask for an online help file {keyboardname}.php in a folder called "help" under the "source" folder. This often is the text from the body of welcome.htm, with a PHP header added. Eventually we hope to unify the process so the same source can provide both the online help and the help packaged with the keyboard.

If your keyboard supports only a desktop layout, you can specify "desktop web" as targets. If your keyboard supports both desktop and touch, you can specify "any" for the target. In rare cases, there might be a need for other combinations if some feature used by the keyboard was not available on a particular platform.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants