Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Budukh] committing the Budukh keyboard #3310

Closed
wants to merge 5 commits into from
Closed

[Budukh] committing the Budukh keyboard #3310

wants to merge 5 commits into from

Conversation

KenK-3-21
Copy link
Contributor

No description provided.

@keyman-server
Copy link
Collaborator

Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process.

Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment.

@LornaSIL
Copy link
Contributor

Hi @KenK-3-21 Thanks for the PR! This looks mostly good, but here are a few issues:

  • LICENSE.md needs the Copyright line to begin with the word Copyright so it must be Copyright © 2020-2025 SIL Global.
  • README.md - could you remove the version line/number and then add SIL Global after the copyright sign? © SIL Global. Removing the version helps us not to have to keep updating that file.
  • Please delete the file: budukh.keyboard_info. This used to be needed, but it isn't used anymore. That file is autogenerated from data in the .kps file.
  • In the .kmn can you change the copyright to: store(&COPYRIGHT) '© SIL Global' to be consistent with our new name.
  • In the .kps we now have a "Description" field that needs to be filled in. That is what shows up on the keyboard home page. That's on the Details tab down nearer the bottom. You could include the same text you have in README.md.
  • In the readme.htm could you add the description there too rather than having the "generated from template" text.
  • In the welcome.htm you could remove that "generated from template" paragraph since you have a description lower down.

For any keyboard in the release stream we generally require there to be a budukh/source/help/budukh.php file. That could be created from the text you have in the welcome file, but it needs to have all of these text deleted:

<!DOCTYPE html>
<html lang="en">
<head>
  <meta charset="utf-8">
  <title>Start Using Budukh</title>
  <style type="text/css">
    p { font: 10pt Tahoma; }
    h1 { font: bold 16pt Tahoma; color: #4444cc; margin-bottom: 2px }
    h2 { font: bold 12pt Tahoma; color: #4444cc; }
  </style>
</head>
<body>

<h1>Start Using Budukh</h1>

<p>
    Budukh 1.0 generated from template.
</p>

and replaced by:

<?php 
  $pagename = 'Budukh Keyboard Help';
  $pagetitle = $pagename;
  require_once('header.php');
?>

Then, go to the bottom of the page and delete:


</body>
</html>

If you need help creating that page, let me know. This page is what is displayed online and is linked to from the home page of the keyboard once it's online.

I haven't actually tested the keyboard yet, but hopefully it's fine if you've tested both the desktop and mobile layout.

@KenK-3-21
Copy link
Contributor Author

KenK-3-21 commented Jan 29, 2025 via email

@KenK-3-21
Copy link
Contributor Author

KenK-3-21 commented Feb 4, 2025 via email

@LornaSIL
Copy link
Contributor

LornaSIL commented Feb 5, 2025

Unfortunately, the committed files never made it to the Pull Request.

@KenK-3-21
Copy link
Contributor Author

KenK-3-21 commented Feb 5, 2025 via email

@DavidLRowe
Copy link
Contributor

@KenK-3-21 Great!
Now, you need to delete the budukh.kpj.user file from the pull request. (Be sure to delete the .kpj.user file and NOT the .kpj file!) If you go to that file in the GitHub interface and click on the "..." menu on the right hand side, there should be an option for "Delete file". Click on that and commit the changes.

@DavidLRowe
Copy link
Contributor

@KenK-3-21 Oops! I spoke too soon. The updated files are there, but in the wrong place. They ended up in the root folder instead of in the release/b/ folder.

The easiest thing may be to close this pull request and create a new one with the files in the right location.

@LornaSIL
Copy link
Contributor

LornaSIL commented Feb 6, 2025

Yeah, unfortunately you have the files in two places, one in the root of the repo and another set in release/b/budukh. But the one in the root probably has the files you recently updated.

@KenK-3-21
Delete budukh directory
ce546fc 
deleted because it was not in the release branch.
@KenK-3-21
Add files via upload
eabf048
@KenK-3-21
Copy link
Contributor Author

Closing this pull request

@KenK-3-21 KenK-3-21 closed this Feb 6, 2025
@KenK-3-21 KenK-3-21 deleted the Budukh branch February 6, 2025 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@KenK-3-21 @keyman-server @LornaSIL @DavidLRowe