[khmer_ldml] new Khmer LDML keyboard #3273
Conversation
|
Thank you for your pull request. You'll see a "build failed" message until the Keyman team has reviewed the pull request and manually initiated the build process. Every change committed to this branch will become part of this pull request. When you have finished submitting files and are ready for the Keyman team to review this pull request, please post a "Ready for review" comment. PLEASE NOTE: team capacity for review is limited in December 2024 and will resume in January 2025. We appreciate your patience. |
Nnyny
changed the title
|
Yes, .user files should be deleted.
…On Mon, Feb 3, 2025, 8:18 PM Darcy Wong ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In experimental/k/khmer_ldml/khmer_ldml.user
<#3273 (comment)>:
> + <FullPath>C:\Users\ASUS PC\Documents\Keyman\keyboards\experimental\k\khmer_ldml\source\khmer_ldml.kps</FullPath>
+ </File>
+ <File>
+ <ID>id_MRU2</ID>
+ <Filename>khmer_ldml.kps</Filename>
+ <FileType>.kps</FileType>
+ <FullPath>C:\Users\ASUS PC\Documents\Keyman Developer\Projects\khmer_ldml\source\khmer_ldml.kps</FullPath>
+ </File>
+ <File>
+ <ID>id_MRU3</ID>
+ <Filename>khmer_ldml.xml</Filename>
+ <FileType>.xml</FileType>
+ <FullPath>C:\Users\ASUS PC\Documents\Keyman Developer\Projects\khmer_ldml\source\khmer_ldml.xml</FullPath>
+ </File>
+ </MRU>
+</KeymanDeveloperProjectUser>
Are .user files things we can remove from the PR?
—
Reply to this email directly, view it on GitHub
<#3273 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABV6RI3OD7TNPA36ZHGYMZL2OAPN7AVCNFSM6AAAAABU3U7ETSVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZDKOJRGU2DCMBWG4>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
There was a problem hiding this comment.
This is looking good! I have a few further change requests -- all minor. The name khmer_ldml is not ideal from an end user perspective because it's talking about the technology rather than the feature of the keyboard. Perhaps it should be called "Khmer Smart" or something that emphasizes the automatic fixups it does?
|
|
||
| <h1>Keyboard Layout</h1> | ||
|
|
||
| <!-- Insert Keyboard Layout Images or HTML here --> |
There was a problem hiding this comment.
This is missing user documentation; I know it's in experimental so it'll be okay, but it won't be able to progress to a release keyboard until that is resolved
There was a problem hiding this comment.
Can I use the one from Khmer Angkor keyboard?
|
@mcdurdin, so are we changing the name to "Khmer Smart" or is this need more consideration? |
We should discuss with @MakaraSok for sure! |
|
e.g. khmer_angkor_thmey |
|
khmer_thmey_thmey |
|
User documentation will be updated later in another PR. Please review the changes. |
|
For the "experimental" section, we don't require user documentation. |
|
I'm not qualified to comment on the actual function of the Khmer keyboard, but everything else looks good, except that the "Welcome file:" field ("Details" tab for "Packaging") should point to the "welcome.htm" file. [This field should have been supplied by the New Project function. See keyman issue #13135.] I could try making that change, but since you will likely change the keyboard project name, I'll let you make that change to the packaging file. Congratulations! |
|
Thank you! I'll look into that missing file. |
No description provided.