Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Syntax warning because of "\S" in Python 3.12 #10

Merged
merged 1 commit into from
Nov 10, 2023
Merged

Syntax warning because of "\S" in Python 3.12 #10

merged 1 commit into from
Nov 10, 2023

Conversation

benoit9126
Copy link
Contributor

Close #9

ezekg
ezekg requested changes Nov 10, 2023
View reviewed changes
Copy link
Member

@ezekg ezekg left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR. The code itself looks good. But would you mind splitting up the changes into separate commits and adding more useful commit messages explaining the changes?

.github/workflows/test.yml Outdated Show resolved Hide resolved
machineid/__init__.py Outdated Show resolved Hide resolved
machineid/__init__.py Show resolved Hide resolved
@ezekg ezekg merged commit f9b94a1 into keygen-sh:master Nov 10, 2023
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ezekg ezekg ezekg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Syntax warning because of "\S" in Python 3.12
2 participants
@benoit9126 @ezekg