WIP: version 670

.claude-plugin/plugin.json

@@ -0,0 +1,4 @@
+{
+  "name": "keybase-client-skills",
+  "description": "Development skills for the Keybase client repo"
+}

.claude/skills/electron-screenshot/SKILL.md

@@ -0,0 +1,39 @@
+---
+name: electron-screenshot
+description: This skill should be used when the user asks to "take a desktop screenshot", "screenshot the electron app", "show me the desktop app", "what does the app look like", or mentions checking the Electron/desktop UI visually.
+---
+
+Take a screenshot of the running Electron app via Playwright MCP and display it.
+
+## Prerequisites
+
+The Electron app must be running with remote debugging enabled:
+```
+KB_ENABLE_REMOTE_DEBUG=1 yarn start-hot
+```
+This launches Electron with `--remote-debugging-port=9222`.
+
+## Steps
+
+1. Close the DevTools tab first to avoid stale data. Use `browser_tabs` with action=list, then action=close on the DevTools tab (usually index 0).
+
+2. Select the main app window tab (the one titled "Keybase: ..." — usually index 1 after DevTools is closed it becomes index 0). Use `browser_tabs` with action=list then action=select.
+
+3. Take a screenshot with `browser_take_screenshot`.
+
+4. The screenshot is saved to a temp file. Resize it for token efficiency:
+   ```
+   sips -Z 800 <screenshot_path> --out /tmp/electron-screenshot.png
+   ```
+
+5. Use the Read tool to display `/tmp/electron-screenshot.png` to the user.
+
+## Error Handling
+
+- If Playwright MCP cannot connect, tell the user the Electron app may not be running with remote debugging. Suggest launching with `cd shared && KB_ENABLE_REMOTE_DEBUG=1 yarn start-hot`.
+- If `sips` fails, fall back to displaying the original screenshot directly.
+
+## Notes
+
+- Tab 0 is typically DevTools, Tab 1 is the main app, Tab 2 is the menubar. Always close DevTools first — when it's open, `browser_evaluate` and `browser_snapshot` run against DevTools instead of the app.
+- 800px max dimension gives good legibility with ~90% token savings.

.claude/skills/ios-screenshot/SKILL.md

@@ -0,0 +1,30 @@
+---
+name: ios-screenshot
+description: This skill should be used when the user asks to "take an iOS screenshot", "screenshot the simulator", "show me the iOS app", "what does the screen look like", or mentions checking the iOS simulator UI visually.
+---
+
+Take a screenshot of the booted iOS simulator and display it.
+
+## Steps
+
+1. Capture the screenshot from the booted iOS simulator:
+   ```
+   xcrun simctl io booted screenshot /tmp/ios-screenshot-full.png
+   ```
+
+2. Resize to 800px max dimension for token efficiency (reduces ~90% of tokens vs full 2556px resolution while staying legible):
+   ```
+   sips -Z 800 /tmp/ios-screenshot-full.png --out /tmp/ios-screenshot.png
+   ```
+
+3. Use the Read tool to display `/tmp/ios-screenshot.png` to the user.
+
+4. Clean up the full-size temporary file:
+   ```
+   rm /tmp/ios-screenshot-full.png
+   ```
+
+## Error Handling
+
+- If `xcrun simctl io booted screenshot` fails, tell the user no iOS simulator is currently booted and suggest they launch one (e.g. via Xcode or `xcrun simctl boot "iPhone 17 Pro"`).
+- If `sips` fails, fall back to displaying the full-size screenshot directly.

.claude/skills/visual-diff/SKILL.md

@@ -0,0 +1,84 @@
+---
+name: visual-diff
+description: This skill should be used when the user asks to "compare screenshots", "visual diff", "check for visual regressions", "before and after screenshots", "did the UI change", or mentions comparing the app UI between branches or before/after a change. Also triggered by "take baseline", "take current", or "compare against baseline".
+---
+
+Run a visual regression test by capturing baseline and current screenshots of the app, then comparing them with ImageMagick to find pixel-level differences.
+
+## Determine Platform
+
+Ask the user which platform to test if unclear: **desktop** (Electron via Playwright MCP) or **iOS** (simulator via Maestro). If context makes it obvious (e.g. they're working on iOS code), skip asking.
+
+## Desktop Workflow
+
+### Prerequisites
+- App running with `KB_ENABLE_REMOTE_DEBUG=1 yarn start-hot`
+- ImageMagick installed (`brew install imagemagick`)
+
+### Option A: Automated Scripts (preferred)
+```bash
+# Baseline (on base branch, app running)
+cd shared && node perf/visual-diff-take.js baseline
+
+# Current (on feature branch, app restarted)
+cd shared && node perf/visual-diff-take.js current
+
+# Compare
+cd shared && ./perf/visual-diff-compare.sh
+```
+
+### Option B: Playwright MCP (manual)
+1. Close the DevTools tab (`browser_tabs` action=close index=0), select the app tab.
+2. Navigate to each tab (People, Chat, Files, Crypto, Teams, Git, Devices, Settings) via `browser_snapshot` + `browser_click`.
+3. Take screenshots to `/tmp/visual-diff/baseline/` or `/tmp/visual-diff/current/`.
+4. Run `cd shared && ./perf/visual-diff-compare.sh`.
+
+## iOS Workflow
+
+### Prerequisites
+- iOS Simulator booted with app running and logged in
+- Maestro installed
+- ImageMagick installed
+
+### Steps
+```bash
+# Baseline (on base branch)
+cd shared && ./perf/visual-diff-take-ios.sh baseline
+
+# Current (on feature branch)
+cd shared && ./perf/visual-diff-take-ios.sh current
+
+# Compare
+cd shared && ./perf/visual-diff-compare-ios.sh
+```
+
+Screenshots go to `/tmp/visual-diff-ios/{baseline,current,diff}/`.
+
+## Viewing Results
+
+After comparison, read the diff images to evaluate:
+
+1. Resize each diff image for token efficiency:
+   ```
+   sips -Z 800 /tmp/visual-diff/diff/<tab>.png --out /tmp/visual-diff-resized/<tab>.png
+   ```
+   (Use `/tmp/visual-diff-ios/diff/` for iOS.)
+
+2. Use the Read tool to display each resized diff image.
+
+## Interpreting Diffs
+
+Red pixels indicate differences between baseline and current screenshots.
+
+- **Subpixel noise** (<200px desktop, <500px iOS): Scattered faint red dots from font antialiasing. Safe to ignore.
+- **Dynamic content**: Avatars, timestamps, badges change between runs. Safe to ignore.
+- **COLOR REGRESSION**: Entire icons or text areas are solid red — colors changed (e.g. icon went blue → gray). Investigate.
+- **SIZE/POSITION REGRESSION**: Red outlines or doubled shapes — something shifted. Common cause: `Box2` adding `alignSelf: 'center'` where old code used `<div>`.
+- **Rule of thumb**: Clean text labels + solid red icons = real bug, not noise.
+
+## Typical Session
+
+1. User says "take baseline" → run the baseline capture step.
+2. User makes code changes and restarts app.
+3. User says "compare" or "take current" → run the current capture + comparison.
+4. Display diff images and summarize findings: which tabs changed, whether changes look intentional or are regressions.

.gitignore

@@ -87,6 +87,5 @@ go/keybase_netbsd
 go/keybase_openbsd
 
 .cursor
-.claude
+.claude/settings.local.json
 .*-mcp
-CLAUDE.md

CLAUDE.md

@@ -0,0 +1,19 @@
+## Rules
+- No `Co-Authored-By` in commits. Ever.
+- "Was working before" = base branch (`nojima/HOTPOT-next-670-clean` or `master`), not previous commit.
+- Never use `npm`. Always `yarn`.
+- Never silently drop features/behavior — ask first, present options.
+- No DOM elements (`<div>`, `<span>`, etc.) in plain `.tsx` files — use `Kb.*`. Guard desktop-only DOM with `Styles.isMobile`.
+- Temp files go in `/tmp/`.
+- Remove unused code when editing: styles, imports, vars, params, dead helpers.
+- Comments: no refactoring notes; only add when context isn't obvious from code.
+- Exact versions in `package.json` (no `^`/`~`).
+- Keep `react`, `react-dom`, `react-native`, `@react-native/*` in sync with Expo SDK.
+- When updating deps: edit `package.json` → `yarn` → `yarn pod-install`.
+- When updating `electron`: run `shared/desktop/extract-electron-shasums.sh <version>`.
+
+## Working Directory
+Repo root is `client/`. TS source lives in `shared/`. Always use absolute paths for file ops. For Bash: always `cd shared/` first.
+
+## Validation
+After TS changes (from `shared/`): `yarn lint` then `yarn tsc`. When debugging visually, skip until fix is confirmed. Never delete the ESLint cache.

go/auth/credential_authority_test.go

@@ -59,7 +59,7 @@ func newTestUser(nKeys int) *testUser {
 		sibkeys:  make([]keybase1.KID, nKeys),
 		subkeys:  make([]keybase1.KID, nKeys),
 	}
-	for i := 0; i < nKeys; i++ {
+	for i := range nKeys {
 		ret.sibkeys[i] = genKID()
 		ret.subkeys[i] = genKID()
 	}
@@ -236,7 +236,7 @@ func TestSimple(t *testing.T) {
 	u1 := state.newTestUser(4)
 
 	ng := 3
-	for i := 0; i < 10; i++ {
+	for range 10 {
 		err = credentialAuthority.CheckUserKey(context.TODO(), u1.uid, &u1.username, &u1.sibkeys[0], false)
 		if err != nil {
 			t.Fatal(err)
@@ -283,7 +283,7 @@ func TestCheckUsers(t *testing.T) {
 	state, credentialAuthority := newTestSetup()
 
 	var users, usersWithDud []keybase1.UID
-	for i := 0; i < 10; i++ {
+	for range 10 {
 		u := state.newTestUser(2)
 		users = append(users, u.uid)
 		usersWithDud = append(usersWithDud, u.uid)

go/avatars/fileurilze_nix.go

@@ -1,5 +1,4 @@
 //go:build !windows
-// +build !windows
 
 package avatars
 

go/avatars/fileurlize_windows.go

@@ -1,5 +1,4 @@
 //go:build windows
-// +build windows
 
 package avatars
 

go/avatars/fullcaching.go

@@ -5,6 +5,7 @@ import (
 	"encoding/json"
 	"fmt"
 	"io"
+	"maps"
 	"net/url"
 	"os"
 	"path/filepath"
@@ -97,10 +98,10 @@ type FullCachingSource struct {
 
 	prepareDirs sync.Once
 
-	usersMissBatch  func(interface{})
-	teamsMissBatch  func(interface{})
-	usersStaleBatch func(interface{})
-	teamsStaleBatch func(interface{})
+	usersMissBatch  func(any)
+	teamsMissBatch  func(any)
+	usersStaleBatch func(any)
+	teamsStaleBatch func(any)
 
 	// testing
 	populateSuccessCh chan struct{}
@@ -116,16 +117,16 @@ func NewFullCachingSource(g *libkb.GlobalContext, staleThreshold time.Duration,
 		staleThreshold: staleThreshold,
 		simpleSource:   NewSimpleSource(),
 	}
-	batcher := func(intBatched interface{}, intSingle interface{}) interface{} {
+	batcher := func(intBatched any, intSingle any) any {
 		reqs, _ := intBatched.([]remoteFetchArg)
 		single, _ := intSingle.(remoteFetchArg)
 		return append(reqs, single)
 	}
-	reset := func() interface{} {
+	reset := func() any {
 		return []remoteFetchArg{}
 	}
-	actor := func(loadFn func(libkb.MetaContext, []string, []keybase1.AvatarFormat) (keybase1.LoadAvatarsRes, error)) func(interface{}) {
-		return func(intBatched interface{}) {
+	actor := func(loadFn func(libkb.MetaContext, []string, []keybase1.AvatarFormat) (keybase1.LoadAvatarsRes, error)) func(any) {
+		return func(intBatched any) {
 			reqs, _ := intBatched.([]remoteFetchArg)
 			s.makeRemoteFetchRequests(reqs, loadFn)
 		}
@@ -213,7 +214,7 @@ func (c *FullCachingSource) StartBackgroundTasks(mctx libkb.MetaContext) {
 	c.started = true
 	go c.monitorAppState(mctx)
 	c.populateCacheCh = make(chan populateArg, 100)
-	for i := 0; i < 10; i++ {
+	for range 10 {
 		go c.populateCacheWorker(mctx)
 	}
 	mctx, cancel := mctx.WithContextCancel()
@@ -238,7 +239,7 @@ func (c *FullCachingSource) StopBackgroundTasks(mctx libkb.MetaContext) {
 	}
 }
 
-func (c *FullCachingSource) debug(m libkb.MetaContext, msg string, args ...interface{}) {
+func (c *FullCachingSource) debug(m libkb.MetaContext, msg string, args ...any) {
 	m.Debug("Avatars.FullCachingSource: %s", fmt.Sprintf(msg, args...))
 }
 
@@ -266,7 +267,7 @@ func (c *FullCachingSource) monitorAppState(m libkb.MetaContext) {
 
 func (c *FullCachingSource) processLRUHit(entry lru.DiskLRUEntry) (res lruEntry) {
 	var ok bool
-	if _, ok = entry.Value.(map[string]interface{}); ok {
+	if _, ok = entry.Value.(map[string]any); ok {
 		jstr, _ := json.Marshal(entry.Value)
 		_ = json.Unmarshal(jstr, &res)
 		return res
@@ -488,9 +489,7 @@ func (c *FullCachingSource) makeURL(m libkb.MetaContext, path string) keybase1.A
 
 func (c *FullCachingSource) mergeRes(res *keybase1.LoadAvatarsRes, m keybase1.LoadAvatarsRes) {
 	for username, rec := range m.Picmap {
-		for format, url := range rec {
-			res.Picmap[username][format] = url
-		}
+		maps.Copy(res.Picmap[username], rec)
 	}
 }
 

go/avatars/simple.go

@@ -2,6 +2,7 @@ package avatars
 
 import (
 	"fmt"
+	"maps"
 	"strings"
 
 	"github.com/keybase/client/go/libkb"
@@ -63,14 +64,12 @@ func (s *SimpleSource) makeRes(res *keybase1.LoadAvatarsRes, apiRes apiAvatarRes
 	allocRes(res, names)
 	for index, rec := range apiRes.Pictures {
 		u := names[index]
-		for format, url := range rec {
-			res.Picmap[u][format] = url
-		}
+		maps.Copy(res.Picmap[u], rec)
 	}
 	return nil
 }
 
-func (s *SimpleSource) debug(m libkb.MetaContext, msg string, args ...interface{}) {
+func (s *SimpleSource) debug(m libkb.MetaContext, msg string, args ...any) {
 	m.Debug("Avatars.SimpleSource: %s", fmt.Sprintf(msg, args...))
 }
 

go/avatars/srv.go

@@ -64,12 +64,12 @@ func (s *Srv) GetUserAvatar(username string) (string, error) {
 	return fmt.Sprintf("http://%v/av?typ=user&name=%v&format=square_192&token=%v", addr, username, token), nil
 }
 
-func (s *Srv) debug(msg string, args ...interface{}) {
+func (s *Srv) debug(msg string, args ...any) {
 	s.G().GetLog().Debug("Avatars.Srv: %s", fmt.Sprintf(msg, args...))
 }
 
 func (s *Srv) makeError(w http.ResponseWriter, code int, msg string,
-	args ...interface{},
+	args ...any,
 ) {
 	s.debug("serve: error code: %d msg %s", code, fmt.Sprintf(msg, args...))
 	w.WriteHeader(code)

go/avatars/urlcaching.go

@@ -2,6 +2,7 @@ package avatars
 
 import (
 	"fmt"
+	"maps"
 	"time"
 
 	"github.com/keybase/client/go/libkb"
@@ -36,7 +37,7 @@ func (c *URLCachingSource) StopBackgroundTasks(m libkb.MetaContext) {
 	c.diskLRU.Flush(m.Ctx(), m.G())
 }
 
-func (c *URLCachingSource) debug(m libkb.MetaContext, msg string, args ...interface{}) {
+func (c *URLCachingSource) debug(m libkb.MetaContext, msg string, args ...any) {
 	m.Debug("Avatars.URLCachingSource: %s", fmt.Sprintf(msg, args...))
 }
 
@@ -89,9 +90,7 @@ func (c *URLCachingSource) specLoad(m libkb.MetaContext, names []string, formats
 
 func (c *URLCachingSource) mergeRes(res *keybase1.LoadAvatarsRes, m keybase1.LoadAvatarsRes) {
 	for username, rec := range m.Picmap {
-		for format, url := range rec {
-			res.Picmap[username][format] = url
-		}
+		maps.Copy(res.Picmap[username], rec)
 	}
 }
 

go/bind/dns_ios.go

@@ -2,7 +2,6 @@
 // this source code is governed by the included BSD license.
 //
 //go:build ios
-// +build ios
 
 package keybase
 

go/bind/dns_other.go

@@ -2,7 +2,6 @@
 // this source code is governed by the included BSD license.
 //
 //go:build !ios
-// +build !ios
 
 package keybase