After calling delete_tasks, open a new session #2592
Conversation
rkoumis
commented
May 7, 2025
rkoumis
commented
- the test was failing
- the test was failing
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Hello @rkoumis, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
Summary of Changes
This pull request addresses a failing test in test_database.py related to the delete_tasks method. The change involves ensuring a new database session is opened after calling delete_tasks to properly reflect the changes in the database. The PR description indicates that the test was failing, and the code change adds with db.session.begin(): blocks around the task queries after the delete_tasks calls.
Highlights
- Bug Fix: Addresses a failing test in
test_database.py. - Database Session Management: Ensures a new database session is opened after calling
delete_tasks. - Test Improvement: Adds a docstring to the test function explaining the need for a new session.
Changelog
- tests/test_database.py
- Added a docstring to the
test_delete_tasksmethod explaining the need for a new session. - Wrapped the task queries after
db.delete_taskscalls inwith db.session.begin():blocks to ensure a new session is used.
- Added a docstring to the
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
A session's closed,
Tasks deleted, state exposed,
A new one begins.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a change to the test_delete_tasks method in tests/test_database.py to ensure a new session is opened after calling delete_tasks. This addresses a failing test. The addition of docstrings is also a good practice.
Merge Readiness
The code change appears to address a failing test and includes a helpful docstring. I am unable to directly approve this pull request, and recommend that others review and approve this code before merging. Given the limited scope and the apparent resolution of the issue, the pull request seems to be in good shape for merging, assuming the changes don't introduce any regressions. Since there are no critical or high severity issues, the pull request is likely ready to be merged after another review.
| with db.session.begin(): | ||
| t1 = db.add_url("https://1.com") | ||
| t2 = db.add_path(temp_filename, tags="x86") | ||
| t3 = db.add_url("https://3.com") | ||
| with db.session.begin(): | ||
| assert db.delete_tasks(task_ids=[]) | ||
| assert db.delete_tasks(task_ids=[t1, t2, t3 + 1]) | ||
| with db.session.begin(): |
There was a problem hiding this comment.
Adding a new session here ensures that the subsequent query operates on a fresh database snapshot, reflecting the changes made by delete_tasks. This is crucial for the test's correctness.
| tasks = db.session.query(Task).all() | ||
| assert len(tasks) == 1 | ||
| assert tasks[0].id == t3 | ||
| assert db.delete_tasks(task_ids=[t1, t2]) | ||
| with db.session.begin(): |
There was a problem hiding this comment.
Similar to the previous session, this ensures that the final query accurately reflects the state of the database after the second delete_tasks call.
