remember to close removed connections

kevin1024 · Dec 15, 2023 · d39c26b · d39c26b
1 parent d76c243
commit d39c26b
Showing 1 changed file with 1 addition and 4 deletions.
diff --git a/vcr/patch.py b/vcr/patch.py
@@ -372,10 +372,6 @@ def add_connection_to_pool_entry(self, pool, connection):
         if isinstance(connection, self._connection_class):
             self._connection_pool_to_connections.setdefault(pool, set()).add(connection)
 
-    def remove_connection_to_pool_entry(self, pool, connection):
-        if isinstance(connection, self._connection_class):
-            self._connection_pool_to_connections[self._connection_class].remove(connection)
-
     def __enter__(self):
         return self
 
@@ -386,6 +382,7 @@ def __exit__(self, *args):
                 connection = pool.pool.get()
                 if isinstance(connection, self._connection_class):
                     connections.remove(connection)
+                    connection.close()
                 else:
                     readd_connections.append(connection)
             for connection in readd_connections: