Stabilize syslog hostname filtering test #1277
Open
+22
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Joachim Wiberg <[email protected]>
troglobit
changed the title
mattiaswal
reviewed
Nov 26, 2025
| clientssh.runsh(f"logger -t test -p daemon.info -H {hostname} -h 10.0.0.1 '{message}'") | ||
| time.sleep(2) | ||
| # Give extra time for messages to be received and written to disk on physical hardware | ||
| time.sleep(5) |
Contributor
There was a problem hiding this comment.
Use until here, instead of magic sleep. Move
rc = serverssh.runsh("cat /var/log/router1 2>/dev/null") log_content = rc.stdout if rc.returncode == 0 else ""
to a seperate function and use until on it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
syslog/hostname-filteringtest (introduced in this release cycle) has shown itself to be a bit flaky on physical test systems. The changes introduced in this PR add some basic checks to ensure connectivity between syslog server and client before initiating the test phase.The results of this change have proven successful.
Checklist
Tick relevant boxes, this PR is-a or has-a: