Skip to content

config: scheduler*: change job trigger for available kbuilds #1165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 3, 2025

Conversation

a-wai
Copy link
Contributor

@a-wai a-wai commented May 23, 2025

Until now, test jobs were triggered when corresponding kbuild nodes
were changed to result: pass. This made sense as those nodes would
immediately and always transition to state done upon completion.

As they're now going through the available state when successful, we
can use this event instead for triggering test jobs.

Make this change throughout all scheduler configs, improving
scheduler-chromeos through the use of a corresponding anchor in the
process.

Depends on kernelci/kernelci-core#2882

@a-wai a-wai requested review from nuclearcat, laura-nao and pawiecz May 23, 2025 15:29
a-wai added 2 commits June 2, 2025 09:36
Until now, test jobs were triggered when corresponding `kbuild` nodes
were changed to `result: pass`. This made sense as those nodes would
immediately and always transition to state `done` upon completion.

As they're now going through the `available` state when successful, we
can use this event instead for triggering test jobs.

Make this change throughout all scheduler configs, improving
`scheduler-chromeos` through the use of a corresponding anchor in the
process.

Signed-off-by: Arnaud Ferraris <[email protected]>
There are currently 2 anchors defined with the same entry name:
`test-job-arm64-qualcomm` & `test-job-arm64-qualcomm-media-committers`.
Fix this situation by renaming the latter entry.

Signed-off-by: Arnaud Ferraris <[email protected]>
@a-wai a-wai force-pushed the scheduler-kbuild-available branch from 4644729 to b33a391 Compare June 2, 2025 07:36
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If result is not pass, this means we will try to use failed builds? (which might not have even build artifacts due failed build), or i am wrong?

@a-wai
Copy link
Contributor Author

a-wai commented Jun 3, 2025

No, as kbuilds will transition to available only if the build passes, otherwise they'll go directly to done (same as checkout nodes, actually)

@a-wai a-wai added this pull request to the merge queue Jun 3, 2025
Merged via the queue into kernelci:main with commit 47d0bee Jun 3, 2025
4 checks passed
@a-wai a-wai deleted the scheduler-kbuild-available branch June 3, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants