Skip to content

Fix: remove deprecated 'docker-compose' #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

tollsimy
Copy link
Contributor

@tollsimy tollsimy commented Apr 10, 2025

This PR remove the deprecated docker-compose in favor of the new docker compose. This PR fixes the cycle detected at path issues mentioned in kernelci/kernelci-pipeline#1102.

This closes also #178.

@tollsimy tollsimy force-pushed the fix/docker-compose branch from 604933f to f733b49 Compare April 10, 2025 15:01
Copy link
Member

@nuclearcat nuclearcat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While this feature hasn't been fully deprecated across all distributions yet, it might be helpful to maintain the compatibility layer for now to ensure a smoother transition for users on various systems.

@tollsimy
Copy link
Contributor Author

Unfortunately, there is no way to maintain compatibility since using compose v1 causes breaking issues such as the mentioned cycle detected at path: <> and more. As far as I know the official docker installation on any distro installs docker compose v2 (named docker-compose-plugin) https://docs.docker.com/engine/install/ .

@tollsimy tollsimy force-pushed the fix/docker-compose branch from f733b49 to 301a147 Compare May 15, 2025 15:15
@tollsimy
Copy link
Contributor Author

Added install of official docker packages with new docker compose.

@tollsimy tollsimy requested a review from nuclearcat May 15, 2025 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants