Restructure issues commands
#210
Merged
+520
−199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
aliceinwire
reviewed
Aug 7, 2025
JenySadadia
force-pushed
the
restructure-issues-cmd
branch
from
d2c51f3 to
3c5ac24
Compare
|
Issues command output: |
|
Hi Jeny, thanks for these changes. I'll add some comments:
|
JenySadadia
force-pushed
the
restructure-issues-cmd
branch
2 times, most recently
from
c2bf3ed to
1ab70d3
Compare
Thank you for the feedback.
Addressed all the comments except the last one.
Done.
Done. |
JenySadadia
force-pushed
the
restructure-issues-cmd
branch
from
1ab70d3 to
9ceaec7
Compare
is not filtering by tree/branch
|
1 similar comment
is not filtering by tree/branch
|
I think this was already discussed on the etherpad.
Done. |
JenySadadia
force-pushed
the
restructure-issues-cmd
branch
2 times, most recently
from
df6d8a9 to
910c239
Compare
what etherpad? |
This PR is based on the feedback I received from @padovan |
As per our latest conversation, I'll handle issue filtering from kci-dev side for now.
|
Filtering issues will be handled on this PR or a different PR? |
|
I'll make changes to this PR. |
ok, thanks |
Remove `issues` command group and subcommand handlers as part of command restructuring. Signed-off-by: Jeny Sadadia <[email protected]>
|
Hi @padovan Here is the sample output with issue filtering working: Note: New issues will have a |
JenySadadia
force-pushed
the
restructure-issues-cmd
branch
from
910c239 to
869104f
Compare
To avoid printing error returned from API, use `error_verbose` option while sending GET request to dashboard API. Add the option to `results builds` and `results boots` command. This change is needed to avoid a flood of error message while fetching new/missing issues with `results issues` command. Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
restructure-issues-cmd
branch
from
869104f to
fbc9cde
Compare
|
@JenySadadia sounds good. The 2 issues that don't have next/master in the first incident still have incidents on the tree. As for the NEW tag, let's add it to the beginning of the line:
With |
added 2 commits
August 20, 2025 20:24
Fetch KCIDB issue matching provided ID. Also get associated builds and tests. Sample command: `kci-dev results issue --id <id> --origin <origin>` Signed-off-by: Jeny Sadadia <[email protected]>
`kci-dev results issues` command utilities: - Fetch KCIDB issues from the dashboard with `results issues` command - Filter issues by checkout by providing `--giturl`, `--branch`, `--commit` and `--tree`(optional) options - Get new issues for checkouts with `--new` option - Get failed/inconclusive builds and boots without any associated issues with `--missing` option Signed-off-by: Jeny Sadadia <[email protected]>
JenySadadia
force-pushed
the
restructure-issues-cmd
branch
from
fbc9cde to
5256faf
Compare
Done. Updated the tag to have the red color. |
As we are showing issues, I also think that red is better |
|
This looks like it can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Restructure KCIDB issues related commands.
Modifications:
issuescommand group and subcommand handlers as part of command restructuringresults issuecommandkci-dev results issue --id <id> --origin <origin>results issuescommand--newoptionany associated issues with
--missingoption