Skip to content

Enable --days switch for getting tree list #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JenySadadia
Copy link

@JenySadadia JenySadadia commented Jun 12, 2025

For the command kci-dev results trees, add --days option to provide a period of time in days to
get results for.

Closes #176

@JenySadadia
Copy link
Author

Hello @aliceinwire
The command gives 78 trees even if the number of days passed is 1.
Where the dashboard shows 25 trees when days selected is 1.
Looks like there is some issue with the dashboard API /api/trees-fast/.
Could you please help me to verify?

@JenySadadia
Copy link
Author

Looks like an issue with the dashboard API.
Created kernelci/dashboard#1287

@aliceinwire
Copy link
Member

aliceinwire commented Jun 13, 2025

thanks for this PR and finding a related bug on the dashboard api
will merge this after the dashboard update and be sure that it works correctly

@aliceinwire
Copy link
Member

aliceinwire commented Jun 16, 2025

can you solve the branch conflict with kcidev/subcommands/results/parser.py by adding the missing logging part?

@JenySadadia
Copy link
Author

can you solve the branch conflict with kcidev/subcommands/results/parser.py by adding the missing logging part?

Resolved the conflict.

@@ -8,7 +8,7 @@

from kcidev.libs.common import *

DASHBOARD_API = "https://dashboard.kernelci.org/api/"
DASHBOARD_API = "https://dashboard.kernelci.org:9000/api/"
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, the option interval_in_days only works when port number is specified.
Could you please explain the reason? @aliceinwire @nuclearcat
Do we have multiple instances running for dashboard APIs?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as is using the dashboard api, could this be a dashboard problem?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I doubt that adding a interval_in_days fetch parameters justify the necessity of specify the port number

Copy link
Member

@aliceinwire aliceinwire Jun 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

by the way I tested on my side without specify the port parameters and works correctly

DASHBOARD_API = "https://dashboard.kernelci.org/api/"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do you mean output differs for $ kci-dev --settings ./kci-dev.toml results trees --days 1 and $ kci-dev --settings ./kci-dev.toml results trees --days 7
It doesn't in my case.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So do you mean output differs for $ kci-dev --settings ./kci-dev.toml results trees --days 1 and $ kci-dev --settings ./kci-dev.toml results trees --days 7 It doesn't in my case.

I see. That's the same result also on my side.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it only differs with the port number specified.
Need to ask on the dashboard repo.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JenySadadia thanks

@padovan
Copy link
Contributor

padovan commented Jun 16, 2025

9000 is our staging/dev instance https://staging.dashboard.kernelci.org:9000/
so code lands there first and you will get different behavior from the prod instance often times.

@JenySadadia
Copy link
Author

9000 is our staging/dev instance https://staging.dashboard.kernelci.org:9000/ so code lands there first and you will get different behavior from the prod instance often times.

The URL is https://dashboard.kernelci.org. I think that's the production one.

@aliceinwire
Copy link
Member

aliceinwire commented Jun 16, 2025

we should have DASHBOARD_API not hardcoded but added to the .kci-dev.toml.example and defaulted to something

For the command `kci-dev results trees`, add `--days`
option to provide a period of time in days to
get results for.

Signed-off-by: Jeny Sadadia <[email protected]>
@JenySadadia
Copy link
Author

@aliceinwire This PR is ready to be merged. Could you please approve/create a suggestion?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable passing number of days for getting tree list
3 participants