Repository navigation
fix(issues): return one test row and pin the tests table height - #2164
Merged
Merged
Conversation
* Collapse repeated incidents with DISTINCT ON (test_id) * Add an integration test that files one test twice Closes kernelci#2163 Assisted-by: Cursor Grok 4.7 Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
* Rename the row size to ROW_HEIGHT and set it on group and leaf rows * Forward an optional row style from TableRowMemoized Closes kernelci#1297 Assisted-by: Cursor Grok 4.7 Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
fixup! fix(tests-table): pin virtual rows to a fixed height Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
felipebergamin
approved these changes
Oct 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GET /api/issue/<id>/testsreturns one row per incident. When the same test is filed twice, the tests table renders it twice under onerow.id. A short scroll then grows the scroll height and jumps ahead.The virtualizer also used a 60px row while the rendered rows were shorter, so a fast drag could show a blank gap.
get_issue_testskeeps one row pertest_idwithDISTINCT ON. This stops the repeated row and the scroll that runs away.Closes #2163Closes #1297Fast drag, blank gap:
Fast drag, rows stay filled:
Test plan