refactor/chart refactor - #2055
Merged
Merged
Conversation
Use table-fixed layout with string-based path width and horizontal scroll so columns stay stable while sorting, paginating, and virtualizing rows. Add prefix ellipsis for long paths, 12px tree indent, and group lab summaries matching hardware (count when mixed). Closes kernelci#420 Signed-off-by: Alan Peixinho <alan.peixinho@profusion.mobi>
- Center status pie text via CSS overlay; drop dead chart props - Fix history Y-axis overlap; mark current commit with ChartsReferenceLine - Use Success/Failed/Inconclusive legend; remove unused locales Closes kernelci#40
felipebergamin
approved these changes
Aug 18, 2026
felipebergamin
left a comment
felipebergamin
left a comment
Member
There was a problem hiding this comment.
looking good.
Something I noticed while testing your PR is this horizontal scroll on tabs when using a small screen. Is quite annoying. But was not introduced by this PR so we can fix later.
Contributor
Author
I agree. This was a solution to fix the unacessible buttons on tab on small screens, but we could improve the UI here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What it is
Status pie center text uses a CSS overlay; dead chart props/UI removed.
History chart Y-axis ticks no longer overlap; current commit uses
ChartsReferenceLine.Legend is Success / Failed / Inconclusive; unused locale strings dropped.
Closes #40
How to test