Update SDK to 0.112.0 and add custom WebMCP actions - #218
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
masnwilliams
left a comment
There was a problem hiding this comment.
The SDK migration and WebMCP coverage look good. Please disable automatic retries on custom-tool removal before merge: a successful DELETE with a lost response can be retried into a 404, reporting failure after the tool is gone. Also reconcile the MCP-facing 8 MB source limit with the hosted request-body limit; a note or smaller transport-specific limit is sufficient if large sources are not intended through this route.
masnwilliams
left a comment
There was a problem hiding this comment.
Correction to my earlier changes-requested review: I overstated the severity. The deletion retry and hosted source-size limit are valid edge cases/contract notes, but I do not consider either merge-blocking. My inline comments are updated accordingly. Approving the current head.
Summary
@onkernel/sdkto0.112.0using Bun and update the lockfile. The full TypeScript check found no additional SDK compatibility breaks.toolmetadata, camelCase schemas and annotations, custom source information, andexclude_custom. Preserve all invocation statuses, includingawaiting_submission, without reshaping responses.webmcpaction enum withlist_custom,add_custom, andremove_custom. Validate namespaces, generated IDs, and the 8,000,000-byte UTF-8 source limit. Disable automatic retries for registration and retain no-retry invocation behavior.Validation
bun testwith the CI-pinned Bun 1.3.3: 744 passing tests after merging main, including 23 WebMCP tests covering forwarding, response preservation, validation boundaries, and API/transport errors.bunx tsc --noEmit --incremental false: passed across the repository.bun run buildwith Bun 1.3.3: passed with placeholder OAuth client IDs and a placeholder Clerk publishable key. The initial build without these variables stopped during page-data collection; compilation and type checking passed in both runs.git diff --check: passed.bun run lint: blocked by the existingnext lintscript, which Next.js 16 no longer supports.bun run format:check: flags only the unchangedAGENTS.md.Not tested: live Kernel API/browser execution, authenticated OAuth/Clerk flows, or production deployment. No generated application bundle changes are included.