powerpc/bpf: fix JIT code size calculation of bpf trampoline #8821
Conversation
|
Upstream branch: 5709be4 |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
27c7945 to
4f05866
Compare
|
Upstream branch: be2fea9 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
867f260 to
7f379ec
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
4f05866 to
e9b7177
Compare
|
Upstream branch: 5cffad0 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
7f379ec to
074cf3a
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
e9b7177 to
f106256
Compare
|
Upstream branch: 53ebef5 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
074cf3a to
d1fbd11
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
f106256 to
8b59228
Compare
|
Upstream branch: 6aca583 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
d1fbd11 to
a7687d2
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
8b59228 to
9c93586
Compare
|
Upstream branch: b9c09fb |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
a7687d2 to
78ed4df
Compare
kernel-patches-daemon-bpf
bot
added
V3-ci-fail
V3-ci-pass
and removed
V3-ci-pass
V3-ci-fail
labels
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
9c93586 to
ca1daab
Compare
|
Upstream branch: 60400cd |
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
9afa005 to
993c0c1
Compare
|
Upstream branch: 38d976c |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
d33bb6c to
925f194
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
993c0c1 to
97831b9
Compare
|
Upstream branch: 358b1c0 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
925f194 to
13489e7
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
97831b9 to
c60a0e6
Compare
|
Upstream branch: 358b1c0 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
13489e7 to
ae71349
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
c60a0e6 to
bebc5be
Compare
|
Upstream branch: 7b05f43 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
ae71349 to
77e5372
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
bebc5be to
bc80b4f
Compare
|
Upstream branch: 7b05f43 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
77e5372 to
c41a846
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
bc80b4f to
ad4665c
Compare
|
Upstream branch: 7b05f43 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
c41a846 to
53dc3f8
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
ad4665c to
f363929
Compare
|
Upstream branch: 86870d0 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
53dc3f8 to
7138be5
Compare
kernel-patches-daemon-bpf
bot
force-pushed
the
bpf-next_base
branch
from
f363929 to
632a377
Compare
arch_bpf_trampoline_size() provides JIT size of the BPF trampoline
before the buffer for JIT'ing it is allocated. The total number of
instructions emitted for BPF trampoline JIT code depends on where
the final image is located. So, the size arrived at with the dummy
pass in arch_bpf_trampoline_size() can vary from the actual size
needed in arch_prepare_bpf_trampoline(). When the instructions
accounted in arch_bpf_trampoline_size() is less than the number of
instructions emitted during the actual JIT compile of the trampoline,
the below warning is produced:
WARNING: CPU: 8 PID: 204190 at arch/powerpc/net/bpf_jit_comp.c:981 __arch_prepare_bpf_trampoline.isra.0+0xd2c/0xdcc
which is:
/* Make sure the trampoline generation logic doesn't overflow */
if (image && WARN_ON_ONCE(&image[ctx->idx] >
(u32 *)rw_image_end - BPF_INSN_SAFETY)) {
So, during the dummy pass, instead of providing some arbitrary image
location, account for maximum possible instructions if and when there
is a dependency with image location for JIT'ing.
Fixes: d243b62 ("powerpc64/bpf: Add support for bpf trampolines")
Reported-by: Venkat Rao Bagalkote <[email protected]>
Closes: https://lore.kernel.org/all/[email protected]/
Cc: [email protected] # v6.13+
Acked-by: Naveen N Rao (AMD) <[email protected]>
Tested-by: Venkat Rao Bagalkote <[email protected]>
Signed-off-by: Hari Bathini <[email protected]>
|
Upstream branch: f263336 |
kernel-patches-daemon-bpf
bot
force-pushed
the
series/955580=>bpf-next
branch
from
7138be5 to
19e2783
Compare
|
At least one diff in series https://patchwork.kernel.org/project/netdevbpf/list/?series=955580 irrelevant now. Closing PR. |
Pull request for series with
subject: powerpc/bpf: fix JIT code size calculation of bpf trampoline
version: 3
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=955580