libbpf: fix BTF dedup to support recursive typedef definitions #10232
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle recursive typedefs in BTF deduplication Pahole fails to encode BTF for some Go projects (e.g. Kubernetes and Podman) due to recursive type definitions that create reference loops not representable in C. These recursive typedefs trigger a failure in the BTF deduplication algorithm. This patch extends btf_dedup_ref_type() to properly handle potential recursion for BTF_KIND_TYPEDEF, similar to how recursion is already handled for BTF_KIND_STRUCT. This allows pahole to successfully generate BTF for Go binaries using recursive types without impacting existing C-based workflows. Co-developed-by: Martin Horth <[email protected]> Signed-off-by: Martin Horth <[email protected]> Co-developed-by: Ouail Derghal <[email protected]> Signed-off-by: Ouail Derghal <[email protected]> Co-developed-by: Guilhem Jazeron <[email protected]> Signed-off-by: Guilhem Jazeron <[email protected]> Co-developed-by: Ludovic Paillat <[email protected]> Signed-off-by: Ludovic Paillat <[email protected]> Co-developed-by: Robin Theveniaut <[email protected]> Signed-off-by: Robin Theveniaut <[email protected]> Suggested-by: Tristan d'Audibert <[email protected]> Signed-off-by: Paul Houssel <[email protected]>
Author
|
Upstream branch: f8c67d8 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request for series with
subject: libbpf: fix BTF dedup to support recursive typedef definitions
version: 1
url: https://patchwork.kernel.org/project/netdevbpf/list/?series=1020974