Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix RDT #1

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix RDT #1

wants to merge 2 commits into from

Conversation

Swishilicous
Copy link

No description provided.

@Swishilicous
Copy link
Author

Oh wait this is a Discord only fix I forgot kernel is an electron mod

@Swishilicous
Copy link
Author

Nevermind it's an electron fix I win

@Kyza
Copy link
Contributor

Kyza commented Jan 21, 2023

Is the module NPM no longer working? I'd prefer to keep support for the multiple frameworks that it has if possible.

@Swishilicous
Copy link
Author

Yeah I realized that and am working on a way of incorporating both, the extension downloads from the web store which doesn't have previous version support so I think I'm just gonna download a mirror from the web and have node unzip and load it if react is inputted.

@Kyza
Copy link
Contributor

Kyza commented Jan 21, 2023

The proper license might also need to be included with the extension's source since it's distributed directly.

@Swishilicous
Copy link
Author

Yeah, that's why I'm gonna just download from a mirror.

@Swishilicous
Copy link
Author

I removed fs-extra because the performance gain was minuscule and I don't see it as being justification for an extra package.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Swishilicous @Kyza