Fix rms_normalization and layer_normalization to ensure consistent precision in computations.
#21438
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #21438 +/- ##
=======================================
Coverage 82.72% 82.73%
=======================================
Files 565 565
Lines 55247 55259 +12
Branches 8613 8617 +4
=======================================
+ Hits 45702 45717 +15
- Misses 7433 7437 +4
+ Partials 2112 2105 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
james77777778
changed the title
rms_normalization and layer_normalization to ensure consistent precision in computations and tests.rms_normalization and layer_normalization to ensure consistent precision in computations.
- Add tests. - Fix the numeric stability issue in half precision training. - Update the signature of the Operation.
james77777778
force-pushed
the
fix-rms-layer-norm
branch
from
a85f8c4 to
b49e51d
Compare
|
@fchollet Here I need to explicitly set |
james77777778
changed the title
rms_normalization and layer_normalization to ensure consistent precision in computations.rms_normalization and layer_normalization to ensure consistent precision in computations.
fchollet
approved these changes
Jul 3, 2025
google-ml-butler
bot
added
kokoro:force-run
ready to pull
github-project-automation
bot
moved this from Assigned Reviewer
to Approved by Reviewer
in PR Queue
google-ml-butler
bot
removed
awaiting review
ready to pull
github-project-automation
bot
moved this from Approved by Reviewer
to Merged
in PR Queue
Mohamed-Ashraf273
pushed a commit
to Mohamed-Ashraf273/keras
that referenced
this pull request
Jul 8, 2025
- Add tests. - Fix the numeric stability issue in half precision training. - Update the signature of the Operation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Operation.Ref: https://github.com/google/flax/blob/main/flax/linen/normalization.py