-
Notifications
You must be signed in to change notification settings - Fork 289
update python to 3.10 and Keras to 3.6 #2292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
.github/workflows/actions.yml
Outdated
@@ -20,18 +20,18 @@ jobs: | |||
version: [keras-stable] | |||
include: | |||
- backend: jax | |||
version: keras-3.5 | |||
version: keras-3.6 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is the oldest version of keras we support. i think it's to bump to up to 3.8 if we want, that version is preinstalled in colab, but whatever we do here we should also reflect in our minimum pip package requirement https://github.com/keras-team/keras-hub/blob/master/pyproject.toml#L30
also, we should do a search over the repo and remove any workarounds we had for keras 3.5 or earlier, like
if keras.__version__ < "3.6": |
if keras.__version__ < "3.6": |
in short, we should always test against the oldest version of keras we want to support, whatever that is
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sachinprasadhs did you see this comment? Are you still working on this?
Any change to testing should go with bumping the actual minimal version in pyproject.toml and removing old workarounds. Maybe let's try bumping to 3.8 and changing that stuff.
Description of the change
dot_product_attention
, which was introduced in keras from 3.6 version.Reference
Colab Notebook
Checklist