Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Responsiveness of the nav bar is corrected #146

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kishalaymodak
Copy link

@kishalaymodak kishalaymodak commented Nov 27, 2024

The navigation bar on the Keploy website has a problem where the "Resources" option and the "GitHub" button overlap when viewed on devices with widths between 1090 and 1025 pixels.

Screenshot from 2024-11-28 00-29-01

Now, after resolving the issue, it looks fine.

Screenshot from 2024-11-28 00-30-12

@yaten2302
Copy link
Contributor

Great work @kishalaymodak 👍
LGTM @Aditya-eddy , adding you for a second review :)

className="btn-sm py-3 text-gray-200 bg-secondary-300 hover:text-primary-300 "
>
<span>Sign In</span>
{/*<svg className="w-3 h-3 fill-current hover:text-primary-300 shrink-0 ml-2 -mr-1" viewBox="0 0 12 12" xmlns="http://www.w3.org/2000/svg">*/}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can this comment be removed if it's not required @Aditya-eddy ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants