improved sidebar for visual hierarchy and spacing #654
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e sections Signed-off-by: vaidik-bajpai <[email protected]>
Signed-off-by: vaidik-bajpai <[email protected]>
Signed-off-by: vaidik-bajpai <[email protected]>
Signed-off-by: vaidik-bajpai <[email protected]>
vaidik-bajpai
changed the title
|
Hey @vaidik-bajpai can you please explain what design has been changed currently we are not able to see any changes in this PR |
|
@Achanandhi-M I added a light background to the section that is active. This adds a slight visual highlight, creating some demarcation. And I have also added little more spacing between the nav links to space them out a bit. I was not sure about what needs to be done exactly, so I made only some minor changes to the sidebar. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
Made minor changes to the sidebar to add visual hierarchy and spacing amongst the nav items. Changed the background of the active section for slight highlight. Moreover added some spacing between nav items.
Please feel free to recommend any more changes that are needed or if the existing once need some fixing, It would be much appreciated.
This PR Resolves #2785
Type of change
How Has This Been Tested?
Checklist: