-
Notifications
You must be signed in to change notification settings - Fork 135
Fix pipelines: [docs] Adjust Vale Doc Linter and Prettier configurations Issue #517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Nice Pr 😄. We currently support Unit Test Generation only for Go projects. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you and congratulations 🎉 for opening your very first pull request in keploy
Hi @pratik-mahalle, thanks for raising the PR! |
Hey @Achanandhi-M, Thank you for the review. I think, the main goal of this PR was to adjust the Vale Doc Linter and Prettier configurations to resolve the linter issues we were encountering. As part of this, I needed to update some of the custom style files, including vale_styles/Google/GenderBias.yml, to ensure they aligned with our current linting rules and addressed the specific problems flagged by Vale. |
I’ll get it reviewed by the team and follow up on the merge soon @pratik-mahalle |
The pipelines are still failing @pratik-mahalle |
Hey @khareyash05 , In |
Let me try pushing the recent changes, if it works! |
b53d8bd
to
bd8fdc1
Compare
The pipelines are still failing @pratik-mahalle |
Ok, Looks like some changes got merged in the repo due to which it is failing. I will fix it |
Signed-off-by: Pratik Mahalle <[email protected]>
Signed-off-by: Pratik Mahalle <[email protected]>
…go types - Fix ordinal numbers and unit spacing - Fix quote punctuation - Fix em dash spacing Signed-off-by: Pratik Mahalle <[email protected]>
…go types - Fix ordinal numbers and unit spacing - Fix quote punctuation - Fix em dash spacing Signed-off-by: Pratik Mahalle <[email protected]>
Signed-off-by: Pratik Mahalle <[email protected]>
Signed-off-by: Pratik Mahalle <[email protected]>
* feat: Added Openhospital docs Signed-off-by: Achanandhi-M <[email protected]> * feat: Added Openhospital docs Signed-off-by: Achanandhi-M <[email protected]> --------- Signed-off-by: Achanandhi-M <[email protected]> Signed-off-by: Pratik Mahalle <[email protected]>
Signed-off-by: Achanandhi-M <[email protected]> Signed-off-by: Pratik Mahalle <[email protected]>
Co-authored-by: Tvisha Raji <[email protected]> Co-authored-by: Neha Gupta <[email protected]> Signed-off-by: Pratik Mahalle <[email protected]>
Co-authored-by: Mridul Tripathi <[email protected]> Signed-off-by: Chirag Ghosh <[email protected]> Signed-off-by: Pratik Mahalle <[email protected]>
Signed-off-by: Chirag Ghosh <[email protected]> Signed-off-by: Pratik Mahalle <[email protected]>
Signed-off-by: Pratik Mahalle <[email protected]>
7cc30ce
to
ed6c0b6
Compare
Signed-off-by: Pratik Mahalle <[email protected]>
Signed-off-by: Pratik Mahalle <[email protected]>
Hey @Achanandhi-M, I have fixed the errors and it shows me no errors, I hope it will work now. |
Hey @pratik-mahalle, |
I am not sure why Prettify code pipelines are failing, If you know please let me know @Achanandhi-M |
Hey @pratik-mahalle, The reason the lint action failed is due to this issue: "subject must not be sentence-case, start-case, pascal-case, or upper-case [subject-case]". In your commit, the subject line uses uppercase, which is why it’s failing. Also, the Prettier code error seems to be related to a permission issue. Just checking—did you run the npx prettier --write '**/*.{js,md}' command before pushing? Let me know if you need any help! |
Yeah, I run the |
Sorry @pratik-mahalle , You can see again it is failing |
Yeah, one is failing due to permission and another one is failing due to the commit syntax I think. Can you tell me what could be the reason behind that lint-codebase pipeline failure |
Signed-off-by: Pratik Mahalle <[email protected]>
I have update the commit message and add the required permission also, let`s check if it work or not @Achanandhi-M |
Sorry @pratik-mahalle, |
Okay @Achanandhi-M , I am also figuring it out. Let me know if you find a solution. |
What has changed?
This pull request addresses the issues with failing
Vale Doc Linter
andPrettier
pipelines as described in Issue #2696.Vale
across the documentation files.Prettier
pipeline configuration.Type of change