Added matrix multiplication #471
Conversation
|
| B = [[5, 8, 1, 2], | ||
| [6, 7, 3, 0], | ||
| [4, 5, 9, 1]] | ||
| import pprint |
There was a problem hiding this comment.
Please write imports at the begin of the file.
There was a problem hiding this comment.
I just wanted to import pprint if the user is running .py file otherwise there is no need to import at all.
| [6, 7, 3, 0], | ||
| [4, 5, 9, 1]] | ||
| import pprint | ||
| pprint.pprint(multiply(A,B)) |
There was a problem hiding this comment.
Please write the expected output of the test.
| result[i][j] += A[i][k] * B[k][j] | ||
| return result | ||
|
|
||
| if __name__ == "__main__": |
There was a problem hiding this comment.
Can you write a unit test? See directory tests. It exists for every directory in algorithms a py-file with tests.
There was a problem hiding this comment.
Yeah I guess that was the major issue, will be working on it, thanks
| if it can be multiplied it multiplies them in O(n^3) time | ||
| """ | ||
|
|
||
| def multiply(A: list,B: list)->list: |
There was a problem hiding this comment.
Please put in a space between ,B . And a space between operators like -> or =
| if(colsA != rowsB): | ||
| raise Exception("Matrices cannot be multipled") | ||
|
|
||
| result=[[0 for i in range(colsB)] for j in range(rowsA)]#create a result matrix |
There was a problem hiding this comment.
Instead of [0 for i range(colsB)] you can simply write ([0] * colsB)
(Put an
Xinside the[ ]to denote check mark[X].)If creating a new file :
if done some changes :
other