Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smcp Small Caps #8

Closed
wants to merge 24 commits into from
Closed

Smcp Small Caps #8

wants to merge 24 commits into from

Conversation

typometre
Copy link

The smcp class must'nt have the c2c feature settings which got its own class.

As a fallback for smcp, use font-variant:small-caps

@kennethormandy
Copy link
Owner

Hey, thanks very much for the Pull Request. .smcp doesn’t actually have Caps to Small Caps enabled, though. I’m actually explicitly disabling it with the 0:

/* Enable `onum` and `smcp`, disable `c2sc` */
font-feature-settings: "onum", "smcp", "c2sc" 0;

The font-variant: small-caps; property was omitted on purpose. You can read more about why I did that in the Small Caps section of the docs.

Also—just for future reference—the correct file to edit would be the index.css file in the root of the project. Sorry, this is a common point of confusion whenever it’s necessary to include the compiled CSS in the repo. I will try to improve the contributing documentation for that with #9.

I’m going to close this PR, but feel free to let me know if I’ve misunderstood anything. Thanks very much for taking the time to put this together anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants