[MIG] database_cleanup: Migration to 18.0

database_cleanup/README.rst

@@ -17,13 +17,13 @@ Database cleanup
     :target: http://www.gnu.org/licenses/agpl-3.0-standalone.html
     :alt: License: AGPL-3
 .. |badge3| image:: https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github
-    :target: https://github.com/OCA/server-tools/tree/17.0/database_cleanup
+    :target: https://github.com/OCA/server-tools/tree/18.0/database_cleanup
     :alt: OCA/server-tools
 .. |badge4| image:: https://img.shields.io/badge/weblate-Translate%20me-F47D42.png
-    :target: https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup
+    :target: https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup
     :alt: Translate me on Weblate
 .. |badge5| image:: https://img.shields.io/badge/runboat-Try%20me-875A7B.png
-    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-tools&target_branch=17.0
+    :target: https://runboat.odoo-community.org/builds?repo=OCA/server-tools&target_branch=18.0
     :alt: Try me on Runboat
 
 |badge1| |badge2| |badge3| |badge4| |badge5|
@@ -65,7 +65,7 @@ Bug Tracker
 Bugs are tracked on `GitHub Issues <https://github.com/OCA/server-tools/issues>`_.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-`feedback <https://github.com/OCA/server-tools/issues/new?body=module:%20database_cleanup%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
+`feedback <https://github.com/OCA/server-tools/issues/new?body=module:%20database_cleanup%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.
 
 Do not contact contributors directly about support or help with technical issues.
 
@@ -100,6 +100,6 @@ OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.
 
-This module is part of the `OCA/server-tools <https://github.com/OCA/server-tools/tree/17.0/database_cleanup>`_ project on GitHub.
+This module is part of the `OCA/server-tools <https://github.com/OCA/server-tools/tree/18.0/database_cleanup>`_ project on GitHub.
 
 You are welcome to contribute. To learn how please visit https://odoo-community.org/page/Contribute.

database_cleanup/__manifest__.py

@@ -3,7 +3,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl.html).
 {
     "name": "Database cleanup",
-    "version": "17.0.1.2.1",
+    "version": "18.0.1.0.0",
     "author": "Therp BV,Odoo Community Association (OCA)",
     "website": "https://github.com/OCA/server-tools",
     "depends": ["base"],
@@ -19,7 +19,6 @@
         "views/purge_tables.xml",
         "views/purge_data.xml",
         "views/create_indexes.xml",
-        "views/purge_properties.xml",
         "views/menu.xml",
         "security/ir.model.access.csv",
     ],

database_cleanup/models/__init__.py

@@ -7,4 +7,3 @@
 from . import purge_data
 from . import purge_menus
 from . import create_indexes
-from . import purge_properties

database_cleanup/models/purge_wizard.py

@@ -72,7 +72,7 @@ def select_lines(self):
         return {
             "type": "ir.actions.act_window",
             "name": _("Select lines to purge"),
-            "views": [(False, "tree"), (False, "form")],
+            "views": [(False, "list"), (False, "form")],
             "res_model": self._fields["purge_line_ids"].comodel_name,
             "domain": [("wizard_id", "in", self.ids)],
         }

database_cleanup/readme/CREDIT.md

@@ -0,0 +1 @@
+The migration of this module from 17.0 to 18.0 was financially supported by Camptocamp.

database_cleanup/security/ir.model.access.csv

@@ -15,5 +15,3 @@ access_cleanup_purge_line_data,access_cleanup_purge_line_data,model_cleanup_purg
 access_cleanup_purge_wizard_data,access_cleanup_purge_wizard_data,model_cleanup_purge_wizard_data,base.group_user,1,1,1,1
 access_cleanup_purge_line_menu,access_cleanup_purge_line_menu,model_cleanup_purge_line_menu,base.group_user,1,1,1,1
 access_cleanup_purge_wizard_menu,access_cleanup_purge_wizard_menu,model_cleanup_purge_wizard_menu,base.group_user,1,1,1,1
-access_cleanup_purge_line_property,access_cleanup_purge_line_property,model_cleanup_purge_line_property,base.group_user,1,1,1,1
-access_cleanup_purge_wizard_property,access_cleanup_purge_wizard_property,model_cleanup_purge_wizard_property,base.group_user,1,1,1,1

database_cleanup/static/description/index.html

@@ -369,7 +369,7 @@ <h1 class="title">Database cleanup</h1>
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
 !! source digest: sha256:0cfcda2589a9f11270616e22be3e3560c3360bb96421bba926a9dfd30735398d
 !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! -->
-<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/server-tools/tree/17.0/database_cleanup"><img alt="OCA/server-tools" src="https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/server-tools-17-0/server-tools-17-0-database_cleanup"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/server-tools&amp;target_branch=17.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
+<p><a class="reference external image-reference" href="https://odoo-community.org/page/development-status"><img alt="Beta" src="https://img.shields.io/badge/maturity-Beta-yellow.png" /></a> <a class="reference external image-reference" href="http://www.gnu.org/licenses/agpl-3.0-standalone.html"><img alt="License: AGPL-3" src="https://img.shields.io/badge/licence-AGPL--3-blue.png" /></a> <a class="reference external image-reference" href="https://github.com/OCA/server-tools/tree/18.0/database_cleanup"><img alt="OCA/server-tools" src="https://img.shields.io/badge/github-OCA%2Fserver--tools-lightgray.png?logo=github" /></a> <a class="reference external image-reference" href="https://translation.odoo-community.org/projects/server-tools-18-0/server-tools-18-0-database_cleanup"><img alt="Translate me on Weblate" src="https://img.shields.io/badge/weblate-Translate%20me-F47D42.png" /></a> <a class="reference external image-reference" href="https://runboat.odoo-community.org/builds?repo=OCA/server-tools&amp;target_branch=18.0"><img alt="Try me on Runboat" src="https://img.shields.io/badge/runboat-Try%20me-875A7B.png" /></a></p>
 <p>Clean your Odoo database from remnants of modules, models, columns and
 tables left by uninstalled modules (prior to 7.0) or a homebrew database
 upgrade to a new major version of Odoo.</p>
@@ -407,7 +407,7 @@ <h1><a class="toc-backref" href="#toc-entry-2">Bug Tracker</a></h1>
 <p>Bugs are tracked on <a class="reference external" href="https://github.com/OCA/server-tools/issues">GitHub Issues</a>.
 In case of trouble, please check there if your issue has already been reported.
 If you spotted it first, help us to smash it by providing a detailed and welcomed
-<a class="reference external" href="https://github.com/OCA/server-tools/issues/new?body=module:%20database_cleanup%0Aversion:%2017.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
+<a class="reference external" href="https://github.com/OCA/server-tools/issues/new?body=module:%20database_cleanup%0Aversion:%2018.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**">feedback</a>.</p>
 <p>Do not contact contributors directly about support or help with technical issues.</p>
 </div>
 <div class="section" id="credits">
@@ -439,7 +439,7 @@ <h2><a class="toc-backref" href="#toc-entry-6">Maintainers</a></h2>
 <p>OCA, or the Odoo Community Association, is a nonprofit organization whose
 mission is to support the collaborative development of Odoo features and
 promote its widespread use.</p>
-<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-tools/tree/17.0/database_cleanup">OCA/server-tools</a> project on GitHub.</p>
+<p>This module is part of the <a class="reference external" href="https://github.com/OCA/server-tools/tree/18.0/database_cleanup">OCA/server-tools</a> project on GitHub.</p>
 <p>You are welcome to contribute. To learn how please visit <a class="reference external" href="https://odoo-community.org/page/Contribute">https://odoo-community.org/page/Contribute</a>.</p>
 </div>
 </div>

database_cleanup/tests/__init__.py

@@ -10,5 +10,4 @@
 from . import test_purge_menus
 from . import test_purge_models
 from . import test_purge_modules
-from . import test_purge_properties
 from . import test_purge_tables

database_cleanup/tests/common.py

@@ -15,7 +15,7 @@ def environment():
     """Return an environment with a new cursor for the current database; the
     cursor is committed and closed after the context block.
     """
-    registry = odoo.registry(common.get_db_name())
+    registry = odoo.modules.registry.Registry(common.get_db_name())
     with registry.cursor() as cr:
         yield odoo.api.Environment(cr, ADMIN_USER_ID, {})
 

database_cleanup/tests/test_purge_fields.py

@@ -10,8 +10,9 @@
 # Use post_install to get all models loaded more info: odoo/odoo#13458
 @tagged("post_install", "-at_install")
 class TestCleanupPurgeFields(Common):
-    def setUp(self):
-        super().setUp()
+    @classmethod
+    def setUpClass(self):
+        super().setUpClass()
         with environment() as env:
             # create a nonexistent model
             self.model_name = "x_database.cleanup.test.field.model"
@@ -54,3 +55,11 @@ def test_empty_field(self):
                     ]
                 )
             )
+
+    @classmethod
+    def tearDownClass(self):
+        super().tearDownClass()
+        with environment() as env:
+            model = env["ir.model"].search([("model", "=", self.model_name)])
+            if model:
+                model.unlink()

database_cleanup/tests/test_purge_modules.py

@@ -9,13 +9,15 @@
 # Use post_install to get all models loaded more info: odoo/odoo#13458
 @tagged("post_install", "-at_install")
 class TestCleanupPurgeLineModule(Common):
-    def setUp(self):
-        super().setUp()
+    @classmethod
+    def setUpClass(self):
+        super().setUpClass()
+        self.model_name = "database_cleanup_test"
         with environment() as env:
             # create a nonexistent module
             self.module = env["ir.module.module"].create(
                 {
-                    "name": "database_cleanup_test",
+                    "name": self.model_name,
                     "state": "to upgrade",
                 }
             )
@@ -26,4 +28,13 @@ def test_remove_to_upgrade_module(self):
             module_names = wizard.purge_line_ids.filtered(
                 lambda x: not x.purged
             ).mapped("name")
-            self.assertTrue("database_cleanup_test" in module_names)
+            self.assertTrue(self.model_name in module_names)
+
+    @classmethod
+    def tearDownClass(self):
+        super().tearDownClass()
+        with environment() as env:
+            module = env["ir.module.module"].search([("name", "=", self.model_name)])
+            if module:
+                module.state = "uninstalled"
+                module.unlink()

database_cleanup/views/menu.xml

@@ -63,11 +63,4 @@
         <field name="action" ref="cleanup_create_indexes_wizard_action" />
         <field name="parent_id" ref="menu_database_cleanup" />
     </record>
-
-    <record model="ir.ui.menu" id="menu_purge_property">
-        <field name="name">Purge obsolete properties</field>
-        <field name="sequence" eval="80" />
-        <field name="action" ref="action_purge_property" />
-        <field name="parent_id" ref="menu_database_cleanup" />
-    </record>
 </odoo>