Skip to content
This repository has been archived by the owner on Dec 1, 2018. It is now read-only.

support updating container images as per kubectl set-image #70

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jcderr
Copy link
Contributor

@jcderr jcderr commented Sep 6, 2016

No description provided.

@aabed
Copy link

aabed commented Dec 14, 2016

@brosner can you please take a look at this change, I believe it will be nice to have such a feature

@brosner brosner added this to the 0.15.0 milestone Dec 21, 2016
@mvid
Copy link

mvid commented Jan 6, 2017

Hey, I implemented this method in my product and it worked as expected. +1

@brosner brosner self-requested a review March 6, 2017 18:25
Copy link
Contributor

@brosner brosner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am a little concerned by this change for a couple of reasons:

  1. image getter/setter is dealing with multiple images. The correct naming should be images IMO.
  2. Implementing these methods on ReplicatedMixin is going to lead to misleading on expected behavior IMO. While we are just doing object updates, I'd like to try to avoid cases where every object inheriting from ReplicatedMixin would behave the same. For example, the only object that inherits from ReplicatedMixin that would behave like set-image (which is actually replica sets) is Deployment.

Due to this being an improved API over what is already possible, I'd like to punt to another release. I think there is merit in this change, but needs to be more thought through when exposing object attributes at the Python object namespace.

@brosner brosner removed this from the 0.15.0 milestone Mar 6, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants