Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add from_address in func compute_message_hash_sn_to_appc #41

Merged
merged 2 commits into from
Sep 9, 2024
Merged

add from_address in func compute_message_hash_sn_to_appc #41

merged 2 commits into from
Sep 9, 2024

Conversation

suiwater
Copy link
Contributor

@suiwater suiwater commented Sep 6, 2024 •
edited by glihm
Loading

Closes #25.

glihm
glihm reviewed Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment and we should be good, thank you for this!

src/messaging/hash.cairo Show resolved Hide resolved
glihm
glihm approved these changes Sep 9, 2024
View reviewed changes
Copy link
Collaborator

@glihm glihm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you @suiwater for the good catch and fixing it.

@glihm glihm merged commit a9c015e into keep-starknet-strange:main Sep 9, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glihm glihm glihm approved these changes

@drspacemn drspacemn Awaiting requested review from drspacemn

@b-j-roberts b-j-roberts Awaiting requested review from b-j-roberts b-j-roberts is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[bug] add from_address in func compute_message_hash_sn_to_appc
2 participants
@suiwater @glihm