feat: add upgradeability #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byteZorvin
requested review from
drspacemn,
glihm and
b-j-roberts
as code owners
glihm
requested changes
Sep 3, 2024
src/appchain.cairo
Outdated
| #[abi(embed_v0)] | ||
| impl UpgradeableImpl of IUpgradeable<ContractState> { | ||
| fn upgrade(ref self: ContractState, new_class_hash: ClassHash) { | ||
| // This function can only be called by the owner |
There was a problem hiding this comment.
Comment that could be removed as code is self-explanatory.
src/appchain.cairo
Outdated
| // This function can only be called by the owner | ||
| self.ownable.assert_only_owner(); | ||
|
|
||
| // Replace the class hash upgrading the contract |
There was a problem hiding this comment.
Same here, comment could be removed as very self-explanatory.
glihm
approved these changes
Sep 5, 2024
There was a problem hiding this comment.
We don't have a test for that, but could be handled in an other PR if you want.
Thanks for the contribution @byteZorvin! 🚀
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr add upgradeability using the Openzeppelin's upgradeable component