fix TestValidatingAdmissionPolicyCrossWorkspaceAPIBinding flaky test

[olamilekan000]

Summary

change fixes TestValidatingAdmissionPolicyCrossWorkspaceAPIBinding by creating the default namespace if it doesn't exist.

What Type of PR Is This?

/kind bug

Related Issue(s)

Fixes 3753

Release Notes

Fixed TestValidatingAdmissionPolicyCrossWorkspaceAPIBinding flaky test.

[kcp-ci-bot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ntnn for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

[olamilekan000]

/retest

[ntnn]

This and the change below is more a bandaid instead of a fix. It'd be better to address the root cause of the missing namespace.

Looking at this code this has been a problem in the past:

kcp/test/e2e/reconciler/workspacedeletion/controller_test.go

Lines 103 to 122 in c885efc

	t.Logf("Wait until the %q workspace is ready", workspace.Name)
	kcptestinghelpers.Eventually(t, func() (bool, string) {
	workspace, err := server.kcpClusterClient.Cluster(orgPath).TenancyV1alpha1().Workspaces().Get(ctx, workspace.Name, metav1.GetOptions{})
	require.NoError(t, err, "failed to get workspace")
	if actual, expected := workspace.Status.Phase, corev1alpha1.LogicalClusterPhaseReady; actual != expected {
	return false, fmt.Sprintf("workspace phase is %s, not %s", actual, expected)
	}
	return workspace.Status.Phase == corev1alpha1.LogicalClusterPhaseReady, fmt.Sprintf("workspace phase is %s", workspace.Status.Phase)
	}, wait.ForeverTestTimeout, time.Millisecond*100, "failed to wait for workspace %s to become ready", orgPath.Join(workspace.Name))
	workspaceCluster := orgPath.Join(workspace.Name)
	t.Logf("Wait for default namespace to be created")
	kcptestinghelpers.Eventually(t, func() (bool, string) {
	_, err := server.kubeClusterClient.Cluster(workspaceCluster).CoreV1().Namespaces().Get(ctx, "default", metav1.GetOptions{})
	if err != nil {
	return false, err.Error()
	}
	return true, ""
	}, wait.ForeverTestTimeout, 100*time.Millisecond, "default namespace was never created")

Instead of waiting on the namespace it would be preferable to inspect why the workspace phase is set to ready before the default namespace is present.

[mjudeikis]

yap, this is not the fix. + it will try to create namespace where workspace bootstrap process does the same. THis might cause other isues

[mjudeikis]

/test all

[mjudeikis]

/retest

[mjudeikis]

my attempt to fix this #3777
I think informers might been leaking a bit in the implementation

[olamilekan000]

Fixed by: #3777