Skip to content

feat: make saturation generic over the number type #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

kayagokalp
Copy link
Owner

This makes the entire pipeline generic over the saturation number type, which enables easy experimentation with fractional and floats during the saturation. There are some limitations around egg, specifically define_language! macro which prevents me from making the language itself generic as well.

@kayagokalp kayagokalp added enhancement New feature or request tech-debt Everything related to tech-debt and various chores labels Jun 20, 2024
@kayagokalp kayagokalp self-assigned this Jun 20, 2024
@kayagokalp kayagokalp changed the title feat: make saturation generic over the saturation number type feat: make saturation generic over the number type Jun 20, 2024
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

Attention: Patch coverage is 67.94521% with 117 lines in your changes missing coverage. Please review.

Project coverage is 53.27%. Comparing base (672f79f) to head (f6572f5).

Files Patch % Lines
fluido-generation/src/lib.rs 0.00% 87 Missing ⚠️
fluido-core/src/lib.rs 0.00% 13 Missing ⚠️
fluido-types/src/number.rs 93.44% 8 Missing ⚠️
e2e-tests/src/harness.rs 0.00% 4 Missing ⚠️
fluido-parse/src/parser.rs 88.23% 2 Missing ⚠️
fluido-ir/src/graph.rs 91.66% 1 Missing ⚠️
fluido-types/src/fluid.rs 98.24% 1 Missing ⚠️
fluido/src/main.rs 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
+ Coverage   49.27%   53.27%   +3.99%     
==========================================
  Files          20       20              
  Lines        1656     1819     +163     
==========================================
+ Hits          816      969     +153     
- Misses        840      850      +10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request tech-debt Everything related to tech-debt and various chores
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant