feat: implement fractional numbers and serialization tests #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kayagokalp
added
enhancement
kayagokalp
force-pushed
the
kayagokalp/fractional
branch
from
44cba98 to
fd29e7f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
+ Coverage 28.33% 34.25% +5.92%
==========================================
Files 20 20
Lines 1426 1524 +98
==========================================
+ Hits 404 522 +118
+ Misses 1022 1002 -20 ☔ View full report in Codecov by Sentry. |
|
related to #45 |
kayagokalp
force-pushed
the
kayagokalp/fractional
branch
from
fd29e7f to
acc9dd5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds fracitonal number is the form of
numerator / 2^(frac_power). This is not used during saturation right now but will be in the upcoming PRs. Also adds couple of tests. Now we have %100 line coverage in numbers.rs module.