142. Linked List Cycle II.md #5
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oda
reviewed
Nov 16, 2024
|
|
||
| なにはともあれ、フロイドの循環検出も実装してみる。 | ||
|
|
||
| - ヘルパー関数を使った方がわかりやすい気がした。 |
There was a problem hiding this comment.
構造の前後を入れ替えたいときに、
https://discord.com/channels/1084280443945353267/1221030192609493053/1225674901445283860
- 関数化。
- Python 独特の文法。
- 無限ループを使う。
などの方法があります。
oda
reviewed
Nov 16, 2024
| def find_meeting_point(head: Optional[ListNode]) -> Optional[ListNode]: | ||
| fast = head | ||
| slow = head | ||
| meeting_node = None |
hayashi-ay
reviewed
Nov 16, 2024
| return slow | ||
| return None | ||
|
|
||
| fast = find_meeting_point(head) |
There was a problem hiding this comment.
ここでの変数名がfastなのはちょっと気になります。まあ好みの範囲かもしれないですが、うさぎが亀に追いついた後は、どちらも1つずつしか進まないのでslow, fastという命名はちょっと違うなという気持ちがあります。
There was a problem hiding this comment.
ありがとうございます。たしかに・・・
他の方の書き方を見てみたので、まとめ：
- node1, node2とやっているパターン
- from_headという書き方のパターン。
- 142. Linked List Cycle II colorbox/leetcode#18
- from_headと合わせるなら、from_meeting_pointにするとbetterかと思った。とはいえ、slowが一歩づつというのは変わっていない情報なので、あまりこだわらなくていいかも。
konnysh
reviewed
Nov 16, 2024
Comment on lines
+53
to
+58
| while fast is not None and fast.next is not None: | ||
| fast = fast.next.next | ||
| slow = slow.next | ||
| if slow == fast: | ||
| return slow | ||
| return None |
There was a problem hiding this comment.
whileの条件分岐はfastを使っていてnodeの更新もfastからするなら、ifの条件の左辺をfastにしてreturnで返す値もfastにしないのかな～と思いました。
処理は全く変わらないですが、なんとなく気になったところです。
There was a problem hiding this comment.
ありがとうございます。言われるまで全く気づきませんでした。。。
以下、自分の調べたメモ：
- 主語を一致させることが読みやすさにつながる。
- 以前いただいた”主役”の話と似ているかもと思った
- 2. Add Two Numbers.md #4 (comment)
- https://qiita.com/momopoketto7/items/5d41bbc2a98a8380d1b6
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/linked-list-cycle-ii/
URLを間違えていたので修正しました。