Unique Email Addresses.md #13
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hayashi-ay
reviewed
Dec 21, 2024
| class Solution: | ||
| def numUniqueEmails(self, emails: List[str]) -> int: | ||
| def normalize_local_name(local_name: str) -> str: | ||
| local_name = local_name.split('+')[0] |
There was a problem hiding this comment.
せっかくならlocal_nameを使い回さずにそれぞれ別の命名をしてあげても良いかなと思いました。
|
|
||
| # Step 3 | ||
|
|
||
| - N: len(emails), M: len(local_name)として |
There was a problem hiding this comment.
Mがemail自体の長さでなくて、local_nameの長さなのが気になりました。
|
|
||
| 書いた後に気づいたこと。`unique_emails`という名前ならば、シンプルなmailアドレス文字列の集合であって欲しい気がした。 | ||
| - 今回は、`(local_name, domain_name)`というタプルなので、驚きを最小にするために型ヒント書いてみた。 | ||
| - けど、ここまでするなら素直に結合してmailアドレス文字列の集合にした方がいいかも。 |
There was a problem hiding this comment.
自分もこっち派です。上から読んでいって型を見たときになんでtupleなんだろうと思いました
|
|
||
| unique_emails = set() | ||
| for email in emails: | ||
| local_name, domain_name = email.rsplit('@', maxsplit=1) |
There was a problem hiding this comment.
自分が関数に切り出すならmailアドレス全体の正規化処理として切り出すかなと思います。
There was a problem hiding this comment.
上のコメントと合わせですが、（みなさんが多くやってるように）
- アドレス全体を正規化処理する
- メールアドレス文字列をsetで管理する
が素直でしたね。。。ありがとうございます！
|
|
||
| - docsに眼を通す | ||
| - https://docs.python.org/3.12/library/stdtypes.html#str.split | ||
| - maxsplit引数は使ったことがなかったが、不正な入力に対して強くするために、今回は使った方が良さそう。 |
There was a problem hiding this comment.
それでいうと、@が含まれない場合も不正な入力になると思います。splitして返り値のlistの長さを見るとかも選択肢としてありかなと思います。
|
拝見しましたが、いいと思いました。コメント含め勉強になります |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://leetcode.com/problems/unique-email-addresses/description/