Switch ctrl with cmd and fix key recognition for macos #853
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added AA_MacDontSwapCtrlAndMeta attribute before QApplication initialization. Replaced isprintable check with isalnum and isascii to fix key recognition with modifiers and prevent their change to special symbols/letters with option key.
l4zygreed
force-pushed
the
feat/macos_modifiers_fix
branch
from
69e01d7 to
53708a0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixing the issue #852
Added AA_MacDontSwapCtrlAndMeta attribute before QApplication initialization.
To
ctrlbe parsed as<ctrl>and
cmdas<meta>Replaced
isprintable()check withisalnum()plusisascii()to fix key recognition with modifiersand prevent their change to special symbols/letters with option key.
isalnumcheck alone allows special letters likeåß∂ƒand
isasciialone allows special empty symbols which brakes letters in ctrl/meta recognition.Checked changes with both PyQt5 and PyQt6.
Not a python dev, but tried not to make a CtrlMeta swap change to be a garbage code.
Please tell if I need to refactor this.
Will be good if somebody check the changes on Linux/Macos.